Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Regards, Patrick
On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Being directly impacted by this in my work on FMN, I am +1 on this, but I also biased (since I'm impacted), so I would like to have more opinions :)
Thanks, Pierre
On Tue, 7 Jun 2016 14:43:57 +0000 Patrick Uiterwijk puiterwijk@redhat.com wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
So, this is just to improve load time? Or memory? Or both?
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
I'm a bit worried this will cause some confusion as someone will look and not see an account and try and sign up with it, etc.
And I know it's going to cause problems with support in #fedora-admin. The first thing we do when someone comes in with an account problem is use zodbot to search for them. If they don't show up because they are inactive it's going to confuse everyone.
So I am -1 to this for now, but I guess I could be convinced.
kevin
On Tue, Jun 07, 2016 at 12:24:13PM -0600, Kevin Fenzi wrote:
On Tue, 7 Jun 2016 14:43:57 +0000 Patrick Uiterwijk puiterwijk@redhat.com wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
So, this is just to improve load time? Or memory? Or both?
Both I think
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
I'm a bit worried this will cause some confusion as someone will look and not see an account and try and sign up with it, etc.
And I know it's going to cause problems with support in #fedora-admin. The first thing we do when someone comes in with an account problem is use zodbot to search for them. If they don't show up because they are inactive it's going to confuse everyone.
So I am -1 to this for now, but I guess I could be convinced.
.fas uses cached info but .fasinfo queries FAS directly iirc, so if someone comes in and provides its FAS username, .fasinfo will return the info regardless of whether .fas would find it.
Alternatively, we could patch zodbot to retrieve/cache all the nicks regardless of their status.
Pierre
+1 please apply
On 7 June 2016 at 10:43, Patrick Uiterwijk puiterwijk@redhat.com wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Regards, Patrick _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/infrastructure@lists.fedoraproje...
changing to 0 after reading Kevin's reply.
On 7 June 2016 at 14:24, Stephen John Smoogen smooge@gmail.com wrote:
+1 please apply
On 7 June 2016 at 10:43, Patrick Uiterwijk puiterwijk@redhat.com wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Regards, Patrick _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/infrastructure@lists.fedoraproje...
-- Stephen J Smoogen.
On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Based on the discussion we had here, idea: What about inverting the change, keep the behavior the same except and add a filter to restrict the user returned to a specified status?
So something like: https://admin.stg.fedoraproject.org/accounts/user/list/a*?status=active
This should keep the current behavior the same while allowing those who want to restrict the list of users to do so.
Thoughts?
Pierre
On Wed, Jun 8, 2016 at 12:45 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Based on the discussion we had here, idea: What about inverting the change, keep the behavior the same except and add a filter to restrict the user returned to a specified status?
So something like: https://admin.stg.fedoraproject.org/accounts/user/list/a*?status=active
This should keep the current behavior the same while allowing those who want to restrict the list of users to do so.
Sounds like a good option to me. I'll see about preparing the patch if everyone agrees with that.
Thoughts?
Pierre _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/infrastructure@lists.fedoraproje...
On Wed, 8 Jun 2016 13:19:46 +0000 Patrick Uiterwijk puiterwijk@redhat.com wrote:
On Wed, Jun 8, 2016 at 12:45 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Based on the discussion we had here, idea: What about inverting the change, keep the behavior the same except and add a filter to restrict the user returned to a specified status?
So something like: https://admin.stg.fedoraproject.org/accounts/user/list/a*?status=active
This should keep the current behavior the same while allowing those who want to restrict the list of users to do so.
Sounds like a good option to me. I'll see about preparing the patch if everyone agrees with that.
I like that idea much better. ;)
kevin
On Wed, Jun 08, 2016 at 08:32:57AM -0600, Kevin Fenzi wrote:
On Wed, 8 Jun 2016 13:19:46 +0000 Patrick Uiterwijk puiterwijk@redhat.com wrote:
On Wed, Jun 8, 2016 at 12:45 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jun 07, 2016 at 02:43:57PM +0000, Patrick Uiterwijk wrote:
Hi,
Since we currently have to deal with a lot of spam accounts, it would be very useful for our systems, like zodbot and FMN, to not retrieve all of those accounts from FAS.
I have just merged a patch for FAS2 to not return inactive accounts by default, and I would like +1s to push this to production.
The patch is at https://github.com/fedora-infra/fas/pull/161.
Do note that this patch does break the FAS2 API in that it suddenly stops returning inactive users. Please take this into consideration when sending a +1/-1.
Based on the discussion we had here, idea: What about inverting the change, keep the behavior the same except and add a filter to restrict the user returned to a specified status?
So something like: https://admin.stg.fedoraproject.org/accounts/user/list/a*?status=active
This should keep the current behavior the same while allowing those who want to restrict the list of users to do so.
Sounds like a good option to me. I'll see about preparing the patch if everyone agrees with that.
I like that idea much better. ;)
Ok, I went ahead and push this change.
FTR the patch is at: https://github.com/fedora-infra/fas/pull/162
Can be tested via: https://admin.fedoraproject.org/accounts/user/list?search=pin* vs https://admin.fedoraproject.org/accounts/user/list?search=pin*&status=ac...
Thanks for the patch Patrick!
Pierre
infrastructure@lists.fedoraproject.org
-
Kevin Fenzi -
Patrick Uiterwijk -
Pierre-Yves Chibon -
Stephen John Smoogen