My opinion is have at it. Fixing things is always welcome. If you can't commit a fix prepare a patch. Its a great way to be involved and start to help.
Darren VanBuren onekopaka@gmail.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Aug 22, 2009, at 10:04 AM, Mike McGrath wrote:
On Sat, 22 Aug 2009, Darren VanBuren wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
I know that some of you dislike tabs, and when I was adding myself to pager.py, I found there were tabs in the HTML portion as opposed to spaces, and tmz pointed out that several other lines are indented with tabs.
I know it's pretty standard for us to use spaces for indentation, but I wanted to check whether it's okay to change pager.py further than adding myself (which ricky approved of on IRC earlier today).
This is correct, although at the moment unwritten. We prefer 4 spaces to a tab character. Or as Seth says "Tabs are a lie".
-Mike
So what's your opinion on me changing it?
Darren VanBuren onekopaka@gmail.com ==================== http://theoks.net/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin)
iEYEARECAAYFAkqQJawACgkQBkMMSWb0YpYSJQCg4Ye64+aD7gHwsUWli2q9BCWR gg4AoJ1xFzGxF033bopaekxLcpPepj90 =euRS -----END PGP SIGNATURE-----
Fedora-infrastructure-list mailing list Fedora-infrastructure-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
-- Dennis Gilmore
infrastructure@lists.fedoraproject.org