Hi,
We are working on Nuancier [0]. One of the current dependencies is python-fedora [1],which should contain flask_fas_openid. It seems that flask_fas_openid will remain in Python 2 and not be ported to Python 3. Will using Flask-OIDC [2] allow for full Python 3 compatibility?
Regards,
Benson
[0] - https://fedoraproject.org/wiki/Infrastructure_2020/Friday_with_Infra
On Fri, Oct 04, 2019 at 10:06:53AM +0300, Benson Muite wrote:
Hi,
We are working on Nuancier [0]. One of the current dependencies is python-fedora [1],which should contain flask_fas_openid. It seems that flask_fas_openid will remain in Python 2 and not be ported to Python 3. Will using Flask-OIDC [2] allow for full Python 3 compatibility?
While we still want to port nuancier to OIDC, I'll note that flask_fas_openid is python3 compatible already and available in python3-fedora-flask-0.10.0-9.fc31.noarch I've just doubled check and there are only two tests failing with python3 (with 98% test coverage), both of which can be fixed in the tests themselves not in the code base.
Hoping this helps, Pierre
Thanks. Am updating deployment Ansible:
https://github.com/bkmgit/nuancier/blob/master/Vagrantfile.example
https://github.com/bkmgit/nuancier/blob/master/devel/ansible/roles/nuancier-...
When running Vagrant up, seem to get stuck at the following point:
TASK [nuancier-dev : Stamp the database with its current migration] ************ fatal: [nuancier]: FAILED! => {"changed": true, "cmd": "~/.virtualenvs/nuancier/bin/alembic stamp $(~/.virtualenvs/nuancier/bin/alembic heads | awk '{ print $1 }')\n", "delta": "0:00:00.667249", "end": "2019-10-05 08:01:33.941396", "msg": "non-zero return code", "rc": 2, "start": "2019-10-05 08:01:33.274147", "stderr": "Traceback (most recent call last):\n File "/home/vagrant/.virtualenvs/nuancier/bin/alembic", line 10, in <module>\n sys.exit(main())\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 573, in main\n CommandLine(prog=prog).main(argv=argv)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 567, in main\n self.run_cmd(cfg, options)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 547, in run_cmd\n **dict((k, getattr(options, k, None)) for k in kwarg)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/command.py", line 448, in heads\n heads = script.get_revisions(script.get_heads())\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 320, in get_heads\n return list(self.revision_map.heads)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/langhelpers.py", line 230, in __get__\n obj.__dict__[self.__name__] = result = self.fget(obj)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/revision.py", line 72, in heads\n self._revision_map\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/langhelpers.py", line 230, in __get__\n obj.__dict__[self.__name__] = result = self.fget(obj)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/revision.py", line 123, in _revision_map\n for revision in self._generator():\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 112, in _load_revisions\n script = Script._from_filename(self, vers, file_)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 906, in _from_filename\n module = util.load_python_file(dir_, filename)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/pyfiles.py", line 98, in load_python_file\n module = load_module_py(module_id, path)\n File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/compat.py", line 173, in load_module_py\n spec.loader.exec_module(module)\n File "<frozen importlib._bootstrap_external>", line 724, in exec_module\n File "<frozen importlib._bootstrap_external>", line 860, in get_code\n File "<frozen importlib._bootstrap_external>", line 791, in source_to_code\n File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed\n File "/home/vagrant/devel/alembic/versions/7db0e24a2a85_add_submission_end_date.py", line 32\n print 'ERROR', err\n ^\nSyntaxError: Missing parentheses in call to 'print'. Did you mean print('ERROR', err)?\nusage: alembic stamp [-h] [--sql] [--tag TAG] [--purge]\n revisions [revisions ...]\nalembic stamp: error: the following arguments are required: revisions", "stderr_lines": ["Traceback (most recent call last):", " File "/home/vagrant/.virtualenvs/nuancier/bin/alembic", line 10, in <module>", " sys.exit(main())", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 573, in main", " CommandLine(prog=prog).main(argv=argv)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 567, in main", " self.run_cmd(cfg, options)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/config.py", line 547, in run_cmd", " **dict((k, getattr(options, k, None)) for k in kwarg)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/command.py", line 448, in heads", " heads = script.get_revisions(script.get_heads())", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 320, in get_heads", " return list(self.revision_map.heads)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/langhelpers.py", line 230, in __get__", " obj.__dict__[self.__name__] = result = self.fget(obj)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/revision.py", line 72, in heads", " self._revision_map", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/langhelpers.py", line 230, in __get__", " obj.__dict__[self.__name__] = result = self.fget(obj)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/revision.py", line 123, in _revision_map", " for revision in self._generator():", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 112, in _load_revisions", " script = Script._from_filename(self, vers, file_)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/script/base.py", line 906, in _from_filename", " module = util.load_python_file(dir_, filename)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/pyfiles.py", line 98, in load_python_file", " module = load_module_py(module_id, path)", " File "/home/vagrant/.virtualenvs/nuancier/lib/python3.7/site-packages/alembic/util/compat.py", line 173, in load_module_py", " spec.loader.exec_module(module)", " File "<frozen importlib._bootstrap_external>", line 724, in exec_module", " File "<frozen importlib._bootstrap_external>", line 860, in get_code", " File "<frozen importlib._bootstrap_external>", line 791, in source_to_code", " File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed", " File "/home/vagrant/devel/alembic/versions/7db0e24a2a85_add_submission_end_date.py", line 32", " print 'ERROR', err", " ^", "SyntaxError: Missing parentheses in call to 'print'. Did you mean print('ERROR', err)?", "usage: alembic stamp [-h] [--sql] [--tag TAG] [--purge]", " revisions [revisions ...]", "alembic stamp: error: the following arguments are required: revisions"], "stdout": "", "stdout_lines": []}
PLAY RECAP ********************************************************************* nuancier : ok=12 changed=11 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
Ansible failed to complete successfully. Any error output should be visible above. Please fix these errors and try again.
On 10/4/19 10:25 AM, Pierre-Yves Chibon wrote:
On Fri, Oct 04, 2019 at 10:06:53AM +0300, Benson Muite wrote:
Hi,
We are working on Nuancier [0]. One of the current dependencies is python-fedora [1],which should contain flask_fas_openid. It seems that flask_fas_openid will remain in Python 2 and not be ported to Python 3. Will using Flask-OIDC [2] allow for full Python 3 compatibility?
While we still want to port nuancier to OIDC, I'll note that flask_fas_openid is python3 compatible already and available in python3-fedora-flask-0.10.0-9.fc31.noarch I've just doubled check and there are only two tests failing with python3 (with 98% test coverage), both of which can be fixed in the tests themselves not in the code base.
Hoping this helps, Pierre _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro...
On 10/5/19 11:09 AM, Benson Muite wrote:
Thanks. Am updating deployment Ansible:
https://github.com/bkmgit/nuancier/blob/master/Vagrantfile.example
https://github.com/bkmgit/nuancier/blob/master/devel/ansible/roles/nuancier-...
When running Vagrant up, seem to get stuck at the following point:
TASK [nuancier-dev : Stamp the database with its current migration]
File "/home/vagrant/devel/alembic/versions/7db0e24a2a85_add_submission_end_date.py", line 32", " print 'ERROR', err", " ^", "SyntaxError: Missing parentheses in call to 'print'. Did you mean print('ERROR', err)?", "usage: alembic stamp [-h] [--sql] [--tag TAG] [--purge]", " revisions [revisions ...]", "alembic stamp: error: the following arguments are required: revisions"], "stdout": "", "stdout_lines": []}
PLAY RECAP
nuancier : ok=12 changed=11 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
Ansible failed to complete successfully. Any error output should be visible above. Please fix these errors and try again.
Fixed error by changing print statement in
https://github.com/bkmgit/nuancier/blob/master/alembic/versions/7db0e24a2a85...
On Sat, Oct 05, 2019 at 05:33:48PM +0300, Benson Muite wrote:
On 10/5/19 11:09 AM, Benson Muite wrote:
Thanks. Am updating deployment Ansible:
https://github.com/bkmgit/nuancier/blob/master/Vagrantfile.example
https://github.com/bkmgit/nuancier/blob/master/devel/ansible/roles/nuancier-...
When running Vagrant up, seem to get stuck at the following point:
TASK [nuancier-dev : Stamp the database with its current migration]
File "/home/vagrant/devel/alembic/versions/7db0e24a2a85_add_submission_end_date.py", line 32", " print 'ERROR', err", " ^", "SyntaxError: Missing parentheses in call to 'print'. Did you mean print('ERROR', err)?", "usage: alembic stamp [-h] [--sql] [--tag TAG] [--purge]", " revisions [revisions ...]", "alembic stamp: error: the following arguments are required: revisions"], "stdout": "", "stdout_lines": []}
PLAY RECAP
nuancier : ok=12 changed=11 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0
Ansible failed to complete successfully. Any error output should be visible above. Please fix these errors and try again.
Fixed error by changing print statement in
https://github.com/bkmgit/nuancier/blob/master/alembic/versions/7db0e24a2a85...
Good catch! I had checked the code of the core of the application not of the alembic revisions.
Pierre
infrastructure@lists.fedoraproject.org