Hello Florian,
On 20.06.2020 21:13, Florian Fainelli wrote:
Hi,
On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote: Can you share your network configuration again with me?
Find the network config below.
# OK: Last good known version (booting that version is also ok) Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020 armv7l armv7l armv7l GNU/Linux
OK, I suspect what has changed is this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
which, if I remember your configuration correctly means that you now have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces can now run a proper networking stack unlike before where you had to do this via the DSA master network device (eth0). This also means that you should run your DHCP server/client on the bridge master network device now.
Yes, config should be a proper DSA config, see also below. IP config is only on brlan and brwan.
Do the changes need a config change? e.g. net: dsa: b53: Ensure the default VID is untagged https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/dr...
Thnx.
Ciao, Gerhard
Config:
brctl show bridge name bridge id STP enabled interfaces brlan 8000.AAAAAAAAAAAA no lan.101 brlansw 8000.BBBBBBBBBBBB no lan1 lan2 lan3 lan4 brwan 8000.CCCCCCCCCCCC no wan.102 brwansw 8000.DDDDDDDDDDDD no wan
================================================================================
= /etc/systemd/network/30-autogen-eth0.network ================================================================================ [Match] Name=eth0
[Network] VLAN=lan.101 VLAN=wan.102 ================================================================================ = /etc/systemd/network/40-autogen-lan.101.netdev ================================================================================ [NetDev] Name=lan.101 Kind=vlan
[VLAN] Id=101 ================================================================================ = /etc/systemd/network/40-autogen-wan.102.netdev ================================================================================ [NetDev] Name=wan.102 Kind=vlan
[VLAN] Id=102 ================================================================================ = /etc/systemd/network/50-autogen-brlan.netdev ================================================================================ [NetDev] Name=brlan Kind=bridge
[Bridge] DefaultPVID=none VLANFiltering=false STP=false ================================================================================ = /etc/systemd/network/50-autogen-brlansw.netdev ================================================================================ [NetDev] Name=brlansw Kind=bridge
[Bridge] DefaultPVID=none VLANFiltering=true STP=false ================================================================================ = /etc/systemd/network/50-autogen-brwan.netdev ================================================================================ [NetDev] Name=brwan Kind=bridge
[Bridge] DefaultPVID=none VLANFiltering=false STP=false ================================================================================ = /etc/systemd/network/50-autogen-brwansw.netdev ================================================================================ [NetDev] Name=brwansw Kind=bridge
[Bridge] DefaultPVID=none VLANFiltering=true STP=false ================================================================================ = /etc/systemd/network/60-autogen-brlan-lan.101.network ================================================================================ [Match] Name=lan.101
[Network] Bridge=brlan ================================================================================ = /etc/systemd/network/60-autogen-brlansw-lan1.network ================================================================================ [Match] Name=lan1
[Network] Bridge=brlansw
[BridgeVLAN] VLAN=101 EgressUntagged=101 PVID=101 ================================================================================ = /etc/systemd/network/60-autogen-brlansw-lan2.network ================================================================================ [Match] Name=lan2
[Network] Bridge=brlansw
[BridgeVLAN] VLAN=101 EgressUntagged=101 PVID=101 ================================================================================ = /etc/systemd/network/60-autogen-brlansw-lan3.network ================================================================================ [Match] Name=lan3
[Network] Bridge=brlansw
[BridgeVLAN] VLAN=101 EgressUntagged=101 PVID=101 ================================================================================ = /etc/systemd/network/60-autogen-brlansw-lan4.network ================================================================================ [Match] Name=lan4
[Network] Bridge=brlansw
[BridgeVLAN] VLAN=101 EgressUntagged=101 PVID=101 ================================================================================ = /etc/systemd/network/60-autogen-brwansw-wan.102.network ================================================================================ [Match] Name=wan.102
[Network] Bridge=brwansw ================================================================================ = /etc/systemd/network/60-autogen-brwansw-wan.network ================================================================================ [Match] Name=wan
[Network] Bridge=brwansw
[BridgeVLAN] VLAN=102 EgressUntagged=102 PVID=102 ================================================================================ = /etc/systemd/network/60-autogen-brwan-wan.102.network ================================================================================ [Match] Name=wan.102
[Network] Bridge=brwan ================================================================================ = /etc/systemd/network/61-autogen-brlan.network ================================================================================ [Match] Name=brlan
[Network] Address=192.168.39.2/24 Gateway=192.168.39.1 DNS=192.168.39.1 Domains=mydomain ================================================================================ = /etc/systemd/network/61-autogen-brwan.network ================================================================================ [Match] Name=brwan
[Network] Address=192.168.1.1/24
-----Original Message----- From: Gerhard Wiesinger [mailto:lists@wiesinger.com] Sent: Saturday, June 20, 2020 3:37 PM To: Florian Fainelli f.fainelli@gmail.com; arm@lists.fedoraproject.org; Maxime Ripard maxime.ripard@bootlin.com; Chen-Yu Tsai wens@csie.org; LKML linux-kernel@vger.kernel.org; filbar@centrum.cz Subject: [fedora-arm] Re: Banana Pi-R1 - kernel 5.6.0 and later broken - b43 DSA
Hello Florian,
On 20.06.2020 21:13, Florian Fainelli wrote:
Hi,
On 6/20/2020 10:39 AM, Gerhard Wiesinger wrote: Can you share your network configuration again with me?
Find the network config below.
# OK: Last good known version (booting that version is also ok) Linux bpi 5.5.18-200.fc31.armv7hl #1 SMP Fri Apr 17 17:25:00 UTC 2020 armv7l armv7l armv7l GNU/Linux
OK, I suspect what has changed is this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/com mit/?id=8fab459e69abfd04a66d76423d18ba853fced4ab
which, if I remember your configuration correctly means that you now have proper DSA interfaces and so all of the wan, lan1-lan4 interfaces can now run a proper networking stack unlike before where you had to do this via the DSA master network device (eth0). This also means that you should run your DHCP server/client on the bridge master network
device now.
Yes, config should be a proper DSA config, see also below. IP config is only on brlan and brwan.
Do the changes need a config change? e.g. net: dsa: b53: Ensure the default VID is untagged https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/d rivers/net/dsa/b53?id=d965a5432d4c3e6b9c3d2bc1d4a800013bbf76f6
Perchance does this discussion relate to a problem I have been having with espressobin boards with a DSA switch through all of the 5.7 release candidates as well as the 5.7.[1..4] kernels and also the 5.8 release candidates?
[ 13.395629] mv88e6085 d0032004.mdio-mii:01: switch 0x3410 detected: Marvell 88E6341, revision 0 [ 13.417579] libphy: mdio: probed [ 13.692403] Unable to handle kernel paging request at virtual address ffff800011bb4060 [ 13.697711] Mem abort info: [ 13.700610] ESR = 0x96000007 [ 13.703720] EC = 0x25: DABT (current EL), IL = 32 bits [ 13.709177] SET = 0, FnV = 0 [ 13.712336] EA = 0, S1PTW = 0 [ 13.715537] Data abort info: [ 13.718495] ISV = 0, ISS = 0x00000007 [ 13.722448] CM = 0, WnR = 0 [ 13.725487] swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000000081f8000 [ 13.732393] [ffff800011bb4060] pgd=000000003bfff003, p4d=000000003bfff003, pud=000000003bffe003, pmd=000000003bffa003, pte=0000000000000000 [ 13.745298] Internal error: Oops: 96000007 [#1] SMP [ 13.750307] Modules linked in: tag_edsa marvell mv88e6xxx(+) dsa_core bridge mmc_block stp aes_ce_blk llc crypto_simd cryptd aes_ce_cipher crct10dif_ce ghash_ce sha2_ce sdhci_xenon_driver sha256_arm64 sdhci_pltfm sdhci bfq sha1_ce mvneta ehci_orion phylink mvmdio armada_37xx_wdt gpio_regulator cpufreq_dt nfsd auth_rpcgss nfs_acl lockd crypto_safexcel authenc libdes grace sunrpc armada_37xx_cpufreq [ 13.786600] CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.8.0-rc2 #1 [ 13.793225] Hardware name: Globalscale Marvell ESPRESSOBin Board (DT) [ 13.799870] Workqueue: events dbs_work_handler [ 13.804427] pstate: 60400005 (nZCv daif +PAN -UAO BTYPE=--) [ 13.810167] pc : module_put+0x24/0x120 [ 13.814017] lr : do_init_module+0xec/0x270 [ 13.818221] sp : ffff800011bb3c30 [ 13.821627] x29: ffff800011bb3c30 x28: 0000000000000000 [ 13.827091] x27: ffff00003b5d6848 x26: ffff800011bb3ce8 [ 13.832558] x25: 0000000000000000 x24: 0000000000000000 [ 13.838021] x23: ffff800011ac1000 x22: ffff8000117f9ca0 [ 13.843486] x21: 0000000000000002 x20: ffff0000324b6800 [ 13.848953] x19: ffff800011bb3ce8 x18: 0000000000000000 [ 13.854420] x17: 0000000000000000 x16: 0000000000000000 [ 13.859884] x15: 0000000000000000 x14: 0000000000000000 [ 13.865350] x13: 0000000000000000 x12: 0000000000000000 [ 13.870817] x11: 00000000000003d0 x10: 0000000000001a00 [ 13.876280] x9 : ffff80001014622c x8 : fefefefefefefeff [ 13.881747] x7 : 0000000000000018 x6 : 0000000000000001 [ 13.887212] x5 : 0000000000036330 x4 : 0000000000000000 [ 13.892677] x3 : 0000000000000000 x2 : ffff00003b5cbc80 [ 13.898143] x1 : 0000000000000000 x0 : ffff800011bb3ce8 [ 13.903610] Call trace: [ 13.906125] module_put+0x24/0x120 [ 13.909617] do_init_module+0xec/0x270 [ 13.913470] __target_index+0x84/0x1b0 [ 13.917321] __cpufreq_driver_target+0x108/0x140 [ 13.922068] od_update+0xe8/0x130 [ 13.925472] od_dbs_update+0x54/0xb4 [ 13.929147] dbs_work_handler+0x4c/0x90 [ 13.933094] process_one_work+0x1d0/0x470 [ 13.937212] worker_thread+0x180/0x400 [ 13.941066] kthread+0x11c/0x120 [ 13.944382] ret_from_fork+0x10/0x18 [ 13.948060] Code: 910003fd b4000360 a90153f3 aa0003f3 (b9437804) [ 13.954328] ---[ end trace 8ca539fee81d80ce ]--- [ 14.230020] mv88e6085 d0032004.mdio-mii:01: configuring for fixed/rgmii-id link mode [ 14.235846] mv88e6085 d0032004.mdio-mii:01: nonfatal error -95 setting MTU on port 1 [ 14.244946] mv88e6085 d0032004.mdio-mii:01: Link is Up - 1Gbps/Full - flow control off [ 14.248099] mv88e6085 d0032004.mdio-mii:01 wan (uninitialized): PHY [!soc!internal-regs@d0000000!mdio@32004!switch0@1!mdio:11] driver [Marvell 88E6390] (irq=55) [ 14.269699] mv88e6085 d0032004.mdio-mii:01: nonfatal error -95 setting MTU on port 2 [ 14.276124] mv88e6085 d0032004.mdio-mii:01 lan0 (uninitialized): PHY [!soc!internal-regs@d0000000!mdio@32004!switch0@1!mdio:12] driver [Marvell 88E6390] (irq=56) [ 14.293411] mv88e6085 d0032004.mdio-mii:01: nonfatal error -95 setting MTU on port 3 [ 14.299735] mv88e6085 d0032004.mdio-mii:01 lan1 (uninitialized): PHY [!soc!internal-regs@d0000000!mdio@32004!switch0@1!mdio:13] driver [Marvell 88E6390] (irq=57) [ 14.320178] DSA: tree 0 setup
And then it eventually drops into a Dracut menu.
Tim Krantz
-
Gerhard Wiesinger -
Timothy Krantz