libteam February 2014

libteam@lists.fedorahosted.org

4 participants
8 discussions

[jpirko/libteam] efcbc1: libteam: introduce ream_refresh
by GitHub 26 Feb '14

26 Feb '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: efcbc1732ab7631cbc3035f1426d6a5d6dbdda4e https://github.com/jpirko/libteam/commit/efcbc1732ab7631cbc3035f1426d6a5d6d… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-02-26 (Wed, 26 Feb 2014) Changed paths: M include/team.h M libteam/ifinfo.c M libteam/libteam.c Log Message: ----------- libteam: introduce ream_refresh New function used to refresh internal lists and to call connected handlers. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: ad11b18771a87fb9aa2f35e2b8c790de0a20afb1 https://github.com/jpirko/libteam/commit/ad11b18771a87fb9aa2f35e2b8c790de0a… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-02-26 (Wed, 26 Feb 2014) Changed paths: M teamd/teamd.c M teamd/teamd.h Log Message: ----------- teamd: look for existing ports before adding new ones This is handy when we are doing take over of team device. Without this, teamd is not aware of existing ports. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: a3cf54617487a05dc1666a856deace46f9c2df5a https://github.com/jpirko/libteam/commit/a3cf54617487a05dc1666a856deace46f9… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-02-26 (Wed, 26 Feb 2014) Changed paths: M teamd/teamd.c M teamd/teamd.h M teamd/teamd_ctl.c M teamd/teamd_per_port.c Log Message: ----------- teamd: do not remove ports from team dev in case of take over mode Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/37703ae65bb9...a3cf54617487

1 0

No LACPDUs received when port is enabled
by Jonas Johansson 21 Feb '14

21 Feb '14

Hi, I have configured teamd witch the lacp runner. When a port has state disabled, all LACPDU frames are received in lacpdu_recv(), but when LACP has reached an agreement (state "current") the port will become enabled and LACPDU frames are no longer received by the port. After the LACP timeout the state will be changed to "expired" and the port will be disabled and LACPDUs can be received again. In the kernel driver, team.c, the team_handle_frame() will return RX_HANDLER_EXACT when a port is disabled and RX_HANDLER_ANOTHER for an enabled LACP port. This means that the a enabled port will divert all traffic to the team device, which teamd (using lacp) isn't listening to. I made a kernel patch which seems to work. Thoughts? =================================================================== --- linux-3.13.3.orig/drivers/net/team/team_mode_loadbalance.c 2014-02-20 15:06:05.526217543 +0100 +++ linux-3.13.3/drivers/net/team/team_mode_loadbalance.c 2014-02-20 15:06:53.406215408 +0100 @@ -226,6 +226,17 @@ return false; } +static rx_handler_result_t lb_receive(struct team *team, struct team_port *port, + struct sk_buff *skb) +{ + struct ethhdr *eth = eth_hdr(skb); + + if (unlikely(ntohs(eth->h_proto) == ETH_P_SLOW)) + return RX_HANDLER_EXACT; + + return RX_HANDLER_ANOTHER; +} + static int lb_bpf_func_get(struct team *team, struct team_gsetter_ctx *ctx) { struct lb_priv *lb_priv = get_lb_priv(team); @@ -649,6 +660,7 @@ .port_leave = lb_port_leave, .port_disabled = lb_port_disabled, .transmit = lb_transmit, + .receive = lb_receive, }; static const struct team_mode lb_mode = { =================================================================== Jonas Johansson

2 6

[PATCH] teamd: fixed couple comments.
by Flavio Leitner 21 Feb '14

21 Feb '14

It should say 'disabled' instead. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> --- teamd/teamd_runner_activebackup.c | 2 +- teamd/teamd_runner_lacp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/teamd/teamd_runner_activebackup.c b/teamd/teamd_runner_activebackup.c index 7ed860f..b81f5d0 100644 --- a/teamd/teamd_runner_activebackup.c +++ b/teamd/teamd_runner_activebackup.c @@ -440,7 +440,7 @@ static int ab_port_added(struct teamd_context *ctx, teamd_log_err("Failed to load port config."); return err; } - /* Newly added ports are enabled */ + /* Newly added ports are disabled */ err = team_set_port_enabled(ctx->th, tdport->ifindex, false); if (err) { teamd_log_err("%s: Failed to disable port.", tdport->ifname); diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 14f9473..1d35b52 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -1221,7 +1221,7 @@ static int lacp_port_added(struct teamd_context *ctx, goto periodic_callback_del; } - /* Newly added ports are enabled */ + /* Newly added ports are disabled */ err = team_set_port_enabled(ctx->th, tdport->ifindex, false); if (err) { teamd_log_err("%s: Failed to disable port.", tdport->ifname); -- 1.8.5.3

2 1

[jpirko/libteam] fa6912: redhat: fix boolean types in example 2
by GitHub 21 Feb '14

21 Feb '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: fa6912b5cc9082060d90999fd0e9b02bf9263efe https://github.com/jpirko/libteam/commit/fa6912b5cc9082060d90999fd0e9b02bf9… Author: Flavio Leitner <fbl(a)redhat.com> Date: 2014-02-21 (Fri, 21 Feb 2014) Changed paths: M teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 Log Message: ----------- redhat: fix boolean types in example 2 The man-page says runner.active and runner.fast_rate are boolean types. So, change them from '1' to 'true'. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 4f75356a09198d84e37bef98ab094ec9826b23a9 https://github.com/jpirko/libteam/commit/4f75356a09198d84e37bef98ab094ec982… Author: Flavio Leitner <fbl(a)redhat.com> Date: 2014-02-21 (Fri, 21 Feb 2014) Changed paths: M teamd/teamd.c Log Message: ----------- teamd: update hwaddr when changing team's macaddr This patch updates hwaddr which is used by LACP runner to set all ports macaddr. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 37703ae65bb9d567299c1df9828352a744639491 https://github.com/jpirko/libteam/commit/37703ae65bb9d567299c1df9828352a744… Author: Flavio Leitner <fbl(a)redhat.com> Date: 2014-02-21 (Fri, 21 Feb 2014) Changed paths: M teamd/teamd_runner_activebackup.c M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: fixed couple comments. It should say 'disabled' instead. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/c0a2fa95c52a...37703ae65bb9

1 0

[PATCH] teamd: update hwaddr when changing team's macaddr
by Flavio Leitner 21 Feb '14

21 Feb '14

This patch updates hwaddr which is used by LACP runner to set all ports macaddr. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> --- teamd/teamd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/teamd/teamd.c b/teamd/teamd.c index da11f5f..d1e335b 100644 --- a/teamd/teamd.c +++ b/teamd/teamd.c @@ -875,7 +875,7 @@ static int teamd_add_ports(struct teamd_context *ctx) static int teamd_hwaddr_check_change(struct teamd_context *ctx, struct teamd_port *tdport) { - const char *hwaddr; + char *hwaddr; unsigned char hwaddr_len; int err; @@ -893,6 +893,7 @@ static int teamd_hwaddr_check_change(struct teamd_context *ctx, teamd_log_err("Failed to set team device hardware address."); return err; } + ctx->hwaddr = hwaddr; return 0; } -- 1.8.5.3

1 0

[PATCH] redhat: fix boolean types in example 2
by Flavio Leitner 20 Feb '14

20 Feb '14

The man-page says runner.active and runner.fast_rate are boolean types. So, change them from '1' to 'true'. Signed-off-by: Flavio Leitner <fbl(a)redhat.com> --- teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 b/teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 index 19b5e06..56e48da 100644 --- a/teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 +++ b/teamd/redhat/example_ifcfgs/2/ifcfg-team_test0 @@ -4,4 +4,4 @@ ONBOOT="yes" BOOTPROTO=none NETMASK=255.255.255.0 IPADDR=192.168.23.11 -TEAM_CONFIG='{"runner": {"name": "lacp", "active": 1, "fast_rate": 1, "tx_hash": ["eth", "ipv4", "ipv6"]},"link_watch": {"name": "ethtool"}}' +TEAM_CONFIG='{"runner": {"name": "lacp", "active": true, "fast_rate": true, "tx_hash": ["eth", "ipv4", "ipv6"]},"link_watch": {"name": "ethtool"}}' -- 1.8.5.3

1 0

[jpirko/libteam] c0a2fa: initscripts: fix port up before master and port do...
by GitHub 12 Feb '14

12 Feb '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: c0a2fa95c52abe34be7214dfeb69a06a8aa7456d https://github.com/jpirko/libteam/commit/c0a2fa95c52abe34be7214dfeb69a06a8a… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-02-12 (Wed, 12 Feb 2014) Changed paths: M teamd/redhat/initscripts/network-scripts/ifdown-TeamPort M teamd/redhat/initscripts/network-scripts/ifup-TeamPort M teamd/redhat/initscripts_systemd/network-scripts/ifdown-TeamPort M teamd/redhat/initscripts_systemd/network-scripts/ifup-TeamPort Log Message: ----------- initscripts: fix port up before master and port down after master Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[jpirko/libteam] fd0cff: lb: enable/disable port according to linkwatch sta...
by GitHub 03 Feb '14

03 Feb '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: fd0cff78f1c6235bead2530cbaf8830aa65dd9c4 https://github.com/jpirko/libteam/commit/fd0cff78f1c6235bead2530cbaf8830aa6… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-02-03 (Mon, 03 Feb 2014) Changed paths: M teamd/teamd.h M teamd/teamd_per_port.c M teamd/teamd_runner_lacp.c M teamd/teamd_runner_loadbalance.c Log Message: ----------- lb: enable/disable port according to linkwatch state Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam February 2014