libteam April 2014

libteam@lists.fedorahosted.org

4 participants
7 discussions

[jpirko/libteam] 0abdda: teamd: lacp: update actor system (mac) before send...
by GitHub 23 Apr '14

23 Apr '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 0abddaf6df84b0154eae65a7d9839c5039b80687 https://github.com/jpirko/libteam/commit/0abddaf6df84b0154eae65a7d9839c5039… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-23 (Wed, 23 Apr 2014) Changed paths: M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: lacp: update actor system (mac) before sending lacpdu Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: a8e7d65f64b26be81b0ba97ce1c628d0c57374c2 https://github.com/jpirko/libteam/commit/a8e7d65f64b26be81b0ba97ce1c628d0c5… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-23 (Wed, 23 Apr 2014) Changed paths: M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: lacp: "expired" port is not selectable, only "current" Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: ff309e7a2434ccf87acd95a0071cd5d47173c239 https://github.com/jpirko/libteam/commit/ff309e7a2434ccf87acd95a0071cd5d471… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-23 (Wed, 23 Apr 2014) Changed paths: M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: lacp: do not check SYNCHRO flag before enable of port This flag is set after this and it is set according to port_selected. So no need to check it here. Removing this avoids faulty carrier down in some scenarios. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 820f9f21717869b7e82ce2aa3a1a46ca524d44a5 https://github.com/jpirko/libteam/commit/820f9f21717869b7e82ce2aa3a1a46ca52… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-23 (Wed, 23 Apr 2014) Changed paths: M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: lacp: update partner info before setting state The problem is that lacp_port_set_state() calls lacp_port_agg_update() and there, lacp_port->partner is used before it is set. That leads to incorrect behaviour. Fix this by changing order. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/cc9fe0dfaa93...820f9f217178

1 0

[jpirko/libteam] 6c8d2e: teamd: fix port removal when using take_over
by GitHub 10 Apr '14

10 Apr '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 6c8d2e8102ea5613acdf5f01d37346d3d059ff53 https://github.com/jpirko/libteam/commit/6c8d2e8102ea5613acdf5f01d37346d3d0… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-10 (Thu, 10 Apr 2014) Changed paths: M teamd/teamd.c M teamd/teamd.h M teamd/teamd_per_port.c Log Message: ----------- teamd: fix port removal when using take_over There is a bug which causes that when take_over is active, there is not possible to remove ports via ctl. This patch fixes it. Also during the traversing of the port list, we are removing the items. That is clearly use after free situation. Fix this by using safe variant of list_for_each_entry. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 0ae6174f06c3044346bc944f7210d29c32b7c74a https://github.com/jpirko/libteam/commit/0ae6174f06c3044346bc944f7210d29c32… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-10 (Thu, 10 Apr 2014) Changed paths: M man/teamd.8 M teamd/teamd.c M teamd/teamd.h Log Message: ----------- teamd: split --take-over option into --no-quit-destroy It is quite confusing that take_over mode also causes that during the quit, the team dev stays on the system. So introduce no-quit-destroy to take care of the quit part separately. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: cc9fe0dfaa93ad9b389777f115bde7776258a484 https://github.com/jpirko/libteam/commit/cc9fe0dfaa93ad9b389777f115bde77762… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-04-10 (Thu, 10 Apr 2014) Changed paths: M teamd/teamd_link_watch.c Log Message: ----------- teamd: respect currently set user linkup for created linkwatches It fixes a problem during take_over then the link may be up initially but linkwatch would incorrectly assume link down by default. Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/771602afdb9e...cc9fe0dfaa93

1 0

[PATCH] libteam: add SubmittingPatches doc
by Flavio Leitner 02 Apr '14

02 Apr '14

Signed-off-by: Flavio Leitner <fbl(a)redhat.com> --- SubmittingPatches | 46 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 SubmittingPatches diff --git a/SubmittingPatches b/SubmittingPatches new file mode 100644 index 0000000..e8e6ec4 --- /dev/null +++ b/SubmittingPatches @@ -0,0 +1,46 @@ +# How to Submit Patches for libteam # +======================================= + +Send changes to libteam as patches to libteam(a)lists.fedorahosted.org +with copy to jiri(a)resnulli.us. + +Avoid using attachments because usually it doesn't work. +In another words, inline the patch inside the e-mail's body. + +The simplest workflow to send changes is using git. The following +steps will guide you to do the task. + +1) Clone the source code on your local machine. +$ git clone https://github.com/jpirko/libteam.git + +2) Create a local branch for you +$ cd libteam +$ git checkout -b testbranch + +3) Do your changes +<<do some changes>> + +4) Commit them to the repository +$ git commit -a -s + +5) Optionally, you can verify how it looks like in the repo +$ git show + +6) Extract the patch in a standard format into /tmp directory +$ git format-patch origin -o /tmp --subject-prefix "patch libteam" + +7) Use git send-email to send the patch*. +$ git send-email /tmp/0001-somepatch.patch \ + --to=libteam(a)lists.fedorahosted.org --cc=jiri(a)resnulli.us + +And you are done :) + +* You may need to configure smtp in order to send emails, so please + check the "Example" section in the reference [3] below as a start. + +Additional references about git: +[1] http://git-scm.com/docs/gittutorial +[2] http://git-scm.com/docs/gitworkflows.html +[3] http://git-scm.com/docs/git-send-email +[4] http://git-scm.com/book + -- 1.8.5.3

2 1

[jpirko/libteam] 771602: libteam: add SubmittingPatches doc
by GitHub 02 Apr '14

02 Apr '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 771602afdb9e73a5edcb219350ae019f7e0ba32f https://github.com/jpirko/libteam/commit/771602afdb9e73a5edcb219350ae019f7e… Author: Flavio Leitner <fbl(a)redhat.com> Date: 2014-04-02 (Wed, 02 Apr 2014) Changed paths: A SubmittingPatches Log Message: ----------- libteam: add SubmittingPatches doc Signed-off-by: Flavio Leitner <fbl(a)redhat.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[patch libteam] libteam: Use u8 for put/get TEAM_ATTR_OPTION_TYPE
by Jonas Johansson 01 Apr '14

01 Apr '14

Use the same type in libteam and kernel for TEAM_ATTR_OPTION_TYPE. The kernel uses a 8 bit integer (u8). Signed-off-by: Jonas Johansson <jonasj76(a)gmail.com> --- libteam/options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libteam/options.c b/libteam/options.c index 69034bf..16f3e98 100644 --- a/libteam/options.c +++ b/libteam/options.c @@ -258,7 +258,7 @@ int get_options_handler(struct nl_msg *msg, void *arg) !option_attrs[TEAM_ATTR_OPTION_TYPE]) { return NL_SKIP; } - nla_type = nla_get_u32(option_attrs[TEAM_ATTR_OPTION_TYPE]); + nla_type = nla_get_u8(option_attrs[TEAM_ATTR_OPTION_TYPE]); data_attr = option_attrs[TEAM_ATTR_OPTION_DATA]; if (nla_type != NLA_FLAG && !data_attr) return NL_SKIP; @@ -743,7 +743,7 @@ static int set_option_value(struct team_handle *th, struct team_option *option, if (option->id.array_index_used) NLA_PUT_U32(msg, TEAM_ATTR_OPTION_ARRAY_INDEX, option->id.array_index); - NLA_PUT_U32(msg, TEAM_ATTR_OPTION_TYPE, nla_type); + NLA_PUT_U8(msg, TEAM_ATTR_OPTION_TYPE, nla_type); switch (nla_type) { case NLA_U32: NLA_PUT_U32(msg, TEAM_ATTR_OPTION_DATA, *((__u32 *) data)); -- 1.8.3.2

2 1

[jpirko/libteam] 07d965: libteam: Use u8 for put/get TEAM_ATTR_OPTION_TYPE
by GitHub 01 Apr '14

01 Apr '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 07d965bfcbdf80b3c63151101ef457f7f6d9183f https://github.com/jpirko/libteam/commit/07d965bfcbdf80b3c63151101ef457f7f6… Author: Jonas Johansson <jonasj76(a)gmail.com> Date: 2014-04-01 (Tue, 01 Apr 2014) Changed paths: M libteam/options.c Log Message: ----------- libteam: Use u8 for put/get TEAM_ATTR_OPTION_TYPE Use the same type in libteam and kernel for TEAM_ATTR_OPTION_TYPE. The kernel uses a 8 bit integer (u8). Signed-off-by: Jonas Johansson <jonasj76(a)gmail.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[PATCH] Use u8 for put/get TEAM_ATTR_OPTION_TYPE
by Jonas Johansson 01 Apr '14

01 Apr '14

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam April 2014