libteam August 2014

libteam@lists.fedorahosted.org

4 participants
12 discussions

[jpirko/libteam] d22e77: teamd: add teamd_zmq_common.h to noinst headers
by GitHub 25 Aug '14

25 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: d22e777495d520a07d532c69f2283a44c01c4166 https://github.com/jpirko/libteam/commit/d22e777495d520a07d532c69f2283a44c0… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-25 (Mon, 25 Aug 2014) Changed paths: M teamd/Makefile.am Log Message: ----------- teamd: add teamd_zmq_common.h to noinst headers Reported-by: Joe Perches <joe(a)perches.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 27b03decbc090d0a2eb91296328aff4e5bdd7599 https://github.com/jpirko/libteam/commit/27b03decbc090d0a2eb91296328aff4e5b… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-25 (Mon, 25 Aug 2014) Changed paths: M libteamdctl/cli_zmq.c M teamd/teamd_zmq_common.h Log Message: ----------- libteamdctl: zmq: remove include of teamd.h Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 0fe29e820ff902b4dc93e9ef57b8faf1571fd044 https://github.com/jpirko/libteam/commit/0fe29e820ff902b4dc93e9ef57b8faf157… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-25 (Mon, 25 Aug 2014) Changed paths: M libteamdctl/cli_zmq.c M teamd/teamd_zmq.c Log Message: ----------- zmq: remove unused my_free_msg Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/1bb4d426c243...0fe29e820ff9

1 0

team: Bug when macvlans are defined on top of the slaves
by erik.hugne＠ericsson.com 22 Aug '14

22 Aug '14

When macvlans are defined on top of the team port devices, the following oops happens immediately when teamd is started. [ 108.224148] team0: Mode changed to "activebackup" [ 108.230450] e1000: eth1 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: None [ 108.234107] 8021q: adding VLAN 0 to HW filter on device eth1 [ 108.235593] BUG: unable to handle kernel NULL pointer dereference at 0000000000000018 [ 108.236397] IP: [<ffffffff815ddb7e>] __mutex_lock_slowpath+0x4e/0x310 [ 108.236397] PGD 3fb2e067 PUD 3fb23067 PMD 0 [ 108.236397] Oops: 0002 [#1] SMP [ 108.236397] Modules linked in: team_mode_activebackup team macvlan [ 108.236397] CPU: 0 PID: 201 Comm: teamd Not tainted 3.16.0+ #237 [ 108.236397] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 108.236397] task: ffff88003f958ed0 ti: ffff88003d15c000 task.ti: ffff88003d15c000 [ 108.236397] RIP: 0010:[<ffffffff815ddb7e>] [<ffffffff815ddb7e>] __mutex_lock_slowpath+0x4e/0x310 [ 108.236397] RSP: 0018:ffff88003d15f698 EFLAGS: 00010046 [ 108.236397] RAX: 0000000000000100 RBX: 0000000000000010 RCX: 0000000000000001 [ 108.236397] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000010 [ 108.236397] RBP: ffff88003d15f6e8 R08: ffff88003f850900 R09: ffff88003e400008 [ 108.236397] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000010 [ 108.236397] R13: ffff88003f958ed0 R14: 0000000000000018 R15: 0000000000000246 [ 108.236397] FS: 00007ff10a811740(0000) GS:ffff88003ec00000(0000) knlGS:0000000000000000 [ 108.236397] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 108.236397] CR2: 0000000000000018 CR3: 000000003fa96000 CR4: 00000000000006f0 [ 108.236397] Stack: [ 108.236397] ffff88003d3d6000 0000000000000081 ffff88003d3d6000 0000000000000001 [ 108.251189] ffff88003d15f710 0000000000000010 0000000000000010 0000000000000001 [ 108.251189] ffff88003d15f7d0 0000000000000000 ffff88003d15f700 ffffffff815dde55 [ 108.251189] Call Trace: [ 108.251189] [<ffffffff815dde55>] mutex_lock+0x15/0x25 [ 108.251189] [<ffffffffa000a0df>] team_port_change_check+0x1f/0x60 [team] [ 108.251189] [<ffffffffa000afc8>] team_device_event+0xa8/0x150 [team] [ 108.251189] [<ffffffff810631ec>] notifier_call_chain+0x4c/0x70 [ 108.251189] [<ffffffff81063301>] raw_notifier_call_chain+0x11/0x20 [ 108.251189] [<ffffffff814b5330>] call_netdevice_notifiers_info+0x30/0x60 [ 108.251189] [<ffffffff814bcdac>] dev_open+0x5c/0x70 [ 108.251189] [<ffffffffa000a582>] team_add_slave+0x2b2/0x6c0 [team] [ 108.251189] [<ffffffff81564390>] ? inet6_fill_ifla6_attrs+0x360/0x390 [ 108.251189] [<ffffffff814cb73e>] do_setlink+0x9be/0xa20 [ 108.251189] [<ffffffff814c99f9>] ? rtnl_fill_ifinfo+0x899/0xb40 [ 108.251189] [<ffffffff814cbdcf>] rtnl_newlink+0x4ff/0x730 [ 108.251189] [<ffffffff814cb9d8>] ? rtnl_newlink+0x108/0x730 [ 108.251189] [<ffffffff814e5e51>] ? netlink_sendskb+0x11/0x40 [ 108.251189] [<ffffffff814e6033>] ? netlink_unicast+0x1b3/0x250 [ 108.251189] [<ffffffff814ca8e0>] ? rtnl_getlink+0x130/0x1d0 [ 108.251189] [<ffffffff814caa70>] rtnetlink_rcv_msg+0x90/0x250 [ 108.251189] [<ffffffff814ca9e0>] ? rtnetlink_rcv+0x30/0x30 [ 108.251189] [<ffffffff814e6739>] netlink_rcv_skb+0xa9/0xc0 [ 108.251189] [<ffffffff814ca9d3>] rtnetlink_rcv+0x23/0x30 [ 108.251189] [<ffffffff814e5fd8>] netlink_unicast+0x158/0x250 [ 108.251189] [<ffffffff8128912d>] ? memcpy_fromiovec+0x4d/0x90 [ 108.251189] [<ffffffff814e6487>] netlink_sendmsg+0x317/0x410 [ 108.251189] [<ffffffff814a0490>] sock_sendmsg+0xa0/0xc0 [ 108.251189] [<ffffffff814a1d68>] ? move_addr_to_kernel+0x38/0x80 [ 108.251189] [<ffffffff814a1d23>] ___sys_sendmsg+0x373/0x380 [ 108.251189] [<ffffffff8103d034>] ? __do_page_fault+0x284/0x520 [ 108.251189] [<ffffffff814a2bbd>] __sys_sendmsg+0x3d/0x80 [ 108.251189] [<ffffffff814a2c0d>] SyS_sendmsg+0xd/0x20 [ 108.251189] [<ffffffff815dfb52>] system_call_fastpath+0x16/0x1b [ 108.251189] Code: 35 20 0d 60 00 45 85 f6 75 13 65 8b 04 25 20 b8 00 00 a9 00 ff 1f 00 0f 85 83 02 00 00 9c 41 5f fa b8 00 01 00 00 4d 8d 74 24 08 <f0> 66 41 0f c1 44 24 08 0f b6 d4 38 c2 0f 85 43 02 00 00 44 8b [ 108.251189] RIP [<ffffffff815ddb7e>] __mutex_lock_slowpath+0x4e/0x310 [ 108.251189] RSP <ffff88003d15f698> [ 108.251189] CR2: 0000000000000018 [ 108.251189] ---[ end trace 97bf1f31f04db01b ]--- Interface config: 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000 link/ether 00:0f:ff:10:03:01 brd ff:ff:ff:ff:ff:ff 3: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 00:0f:ff:11:04:01 brd ff:ff:ff:ff:ff:ff 4: eth2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000 link/ether 00:0f:ff:11:05:01 brd ff:ff:ff:ff:ff:ff 5: macvlan0@eth1: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default link/ether da:ad:a9:57:7a:82 brd ff:ff:ff:ff:ff:ff 6: macvlan1@eth2: <BROADCAST,MULTICAST,M-DOWN> mtu 1500 qdisc noop state DOWN mode DEFAULT group default link/ether e6:4d:af:76:55:a2 brd ff:ff:ff:ff:ff:ff Teamd config: { "device": "team0", "runner": {"name": "activebackup"}, "link_watch": { "name": "arp_ping", "interval": 100, "missed_max": 30, "source_host": "192.168.123.101", "target_host": "192.168.123.1" }, "ports": { "eth1": { "prio": -10, "sticky": true }, "eth2": { "prio": 100 } } } teamd version: v1.12 kernel version: recent net-next (33caee3)

2 1

[jpirko/libteam] ff127a: add forgotten tarball
by GitHub 19 Aug '14

19 Aug '14

Branch: refs/heads/gh-pages Home: https://github.com/jpirko/libteam Commit: ff127a7cbec76cc45329613db6ed4318a2800f7f https://github.com/jpirko/libteam/commit/ff127a7cbec76cc45329613db6ed4318a2… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: A files/libteam-1.12.tar.gz Log Message: ----------- add forgotten tarball Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[jpirko/libteam] 18518f: add v1.12 tarball
by GitHub 19 Aug '14

19 Aug '14

Branch: refs/heads/gh-pages Home: https://github.com/jpirko/libteam Commit: 18518f6ab02d5e2c18a2668abfaa1cc8107e4d56 https://github.com/jpirko/libteam/commit/18518f6ab02d5e2c18a2668abfaa1cc810… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M files/libteam-latest.tar.gz M index.html Log Message: ----------- add v1.12 tarball Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[jpirko/libteam]
by GitHub 19 Aug '14

19 Aug '14

Branch: refs/tags/v1.12 Home: https://github.com/jpirko/libteam

1 0

[jpirko/libteam] 1bb4d4: 1.12 release
by GitHub 19 Aug '14

19 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 1bb4d426c24365e098cae22f41bda227941fe3c3 https://github.com/jpirko/libteam/commit/1bb4d426c24365e098cae22f41bda22794… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M configure.ac Log Message: ----------- 1.12 release Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[jpirko/libteam] 34080b: teamd: fix coverity error in teamd_sriov_physfn_ad...
by GitHub 19 Aug '14

19 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 34080bd1f3534467b1a8fc5c2a36c82170a75ffd https://github.com/jpirko/libteam/commit/34080bd1f3534467b1a8fc5c2a36c82170… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M teamd/teamd_phys_port_check.c Log Message: ----------- teamd: fix coverity error in teamd_sriov_physfn_addr Passing variable "256UL" as argument 3 to function readlink, which returns that argument. The value of "ret" is now 256. Overrunning array "link" of 256 bytes at byte offset 256 using index "ret" (which evaluates to 256). Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 785d6afb6212d9a3143740b8aaa5289370b5f074 https://github.com/jpirko/libteam/commit/785d6afb6212d9a3143740b8aaa5289370… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-19 (Tue, 19 Aug 2014) Changed paths: M teamd/teamd_state.c Log Message: ----------- teamd: teamd_state_val_dump move TEAMD_BUG_ON so it can be actually triggered Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/332dc54e8f59...785d6afb6212

1 0

[jpirko/libteam] 332dc5: libteamdctl: adjust doc comments to be processed b...
by GitHub 18 Aug '14

18 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 332dc54e8f59a9ca794bb3a90791af084fa44f74 https://github.com/jpirko/libteam/commit/332dc54e8f59a9ca794bb3a90791af084f… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M doc/Doxyfile.in M libteamdctl/cli_usock.c M libteamdctl/libteamdctl.c Log Message: ----------- libteamdctl: adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us>

1 0

[jpirko/libteam] 0789f8: add doxygen html doc generation into autoconf
by GitHub 18 Aug '14

18 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 0789f84e679c8832f2967c0b3886e6267897534e https://github.com/jpirko/libteam/commit/0789f84e679c8832f2967c0b3886e62678… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M Makefile.am M configure.ac A doc/Doxyfile.in A doc/Makefile.am Log Message: ----------- add doxygen html doc generation into autoconf Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 805a8c8988bc29f69761d13b9490dadc368bf867 https://github.com/jpirko/libteam/commit/805a8c8988bc29f69761d13b9490dadc36… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M libteam/libteam.c Log Message: ----------- libteam: libteam.c adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 893cfa742f33c60bc3ab630ff6bf0aef5f7a4966 https://github.com/jpirko/libteam/commit/893cfa742f33c60bc3ab630ff6bf0aef5f… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M libteam/ifinfo.c Log Message: ----------- libteam: ifinfo.c adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: bdc46b00d5df77e1d3b8bb37590a5aa5af54d076 https://github.com/jpirko/libteam/commit/bdc46b00d5df77e1d3b8bb37590a5aa5af… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M libteam/options.c Log Message: ----------- libteam: options.c adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 6a95215801e890f1db820a8aaf80e9e49467a030 https://github.com/jpirko/libteam/commit/6a95215801e890f1db820a8aaf80e9e494… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M libteam/ports.c Log Message: ----------- libteam: ports.c adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 94da8d0e97022b98f84714b19eb220091aaf710e https://github.com/jpirko/libteam/commit/94da8d0e97022b98f84714b19eb220091a… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M libteam/stringify.c Log Message: ----------- libteam: stringify.c adjust doc comments to be processed by doxygen Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 85fc6b077c25df6c4a9c182f7f1efdebb753fb52 https://github.com/jpirko/libteam/commit/85fc6b077c25df6c4a9c182f7f1efdebb7… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: R src/.gitignore Log Message: ----------- remove forgotten src dir Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/50ab78baae00...85fc6b077c25

1 0

[jpirko/libteam] 2d19c6: teamd: fix incorrect usage of sizeof in __str_sock...
by GitHub 18 Aug '14

18 Aug '14

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 2d19c6e08390497faf4dce52dc2788eccd9761e7 https://github.com/jpirko/libteam/commit/2d19c6e08390497faf4dce52dc2788eccd… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M teamd/teamd_link_watch.c M teamd/teamd_link_watch.h M teamd/teamd_lw_arp_ping.c M teamd/teamd_lw_nsna_ping.c Log Message: ----------- teamd: fix incorrect usage of sizeof in __str_sockaddr Sizeof will return the size of a pointer, which is not correct intended. Introduced-by: 672ddfd506 ("teamd: move arp ping link watcher to a separate file") Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Acked-by: Flavio Leitner <fbl(a)redhat.com> Commit: dafabe30a705ec3172648544dc0e863ba6a20adb https://github.com/jpirko/libteam/commit/dafabe30a705ec3172648544dc0e863ba6… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M include/private/misc.h Log Message: ----------- fix strncmp len in ifname2ifindex Calling strncpy with a maximum size argument of 16 bytes on destination array "ifr.ifr_ifrn.ifrn_name" of size 16 bytes might leave the destination string unterminated. Introduced-by: b9692cb90 ("teamd: generate team device names in case they are not specified") Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Acked-by: Flavio Leitner <fbl(a)redhat.com> Commit: 50ab78baae0051dd3b0c3a34c7874c80441f0a4d https://github.com/jpirko/libteam/commit/50ab78baae0051dd3b0c3a34c7874c8044… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2014-08-18 (Mon, 18 Aug 2014) Changed paths: M teamd/teamd_lw_tipc.c Log Message: ----------- teamd: tipc: use TIPC_MAX_*_NAME for buffers and check len You might overrun the 255 byte fixed-size string "tipc_ppriv->bearer" by copying "tipc_bearer" without checking the length. Introduced-by: 847046a5c7 ("teamd: add TIPC link watcher") Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Acked-by: Flavio Leitner <fbl(a)redhat.com> Compare: https://github.com/jpirko/libteam/compare/b883f38bcc0b...50ab78baae00

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam August 2014