libteam September 2015

libteam@lists.fedorahosted.org

6 participants
26 discussions

Stange problems with CentOS 7 and roundrobin runner
by Ingo Brand 07 Sep '16

07 Sep '16

Hello, I am currently setting up a high available NFS server cluster with 2 nodes using pacemaker + corosync + drbd + flashcache. The two nodes (media1 and media2) have 4 1G copper nics each. I formed 2 teams: team0: LACP with em1 and em2 connected to a switch for NFS services team1: roundrobin with em3 and em4 and MTU 9000 directly connected with copper patch cables for drbd sync During my testing everything was working as expected. Then I started to tranfer about 20TB from an old server to the new cluster. The copy process was fine for about 32 hours. Then corosync and drbd started to report errors on the roundrobin team1 interface (see logs at the end of this email). The drbd sync and corosync started to flap between states for several hours on team1. I checked the error counters with ifconfig and found a huge amount off TX dropped packets on team1 of the drbd slave node media2. There were NO other error counters raising but team1 on media2. To make this a bit more clear: - team1 on media2 (the drbd slave) showed raising TX dropped packets - em3 and em4 on media2 (the physical interfaces of team1) did not show any raising error counters. - team1 on media1 (the drbd master) did not show any raising error counters. - em3 and em4 on media1 (the physical interfaces of team1) did not show any raising error counters. I then thought maybe one of the two patch cables between the two machines was not 100% ok. So I removed em4 from team1 on both machines: "teamdctl team1 port remove em4" The error counters stopped raising. I thought: "Yeah! That cable must be broken!" But just to make sure I really found the problem I re-enabled em4 on both nodes: "teamdctl team1 port add em4" Ok, now both team1 interfaces had 2 links up again and the error counter restarted to raise again. I then stopped em3 on both nodes to force all traffic through em4: "teamdctl team1 port remove em3" And guess what? The error counters on team1 stopped raising! So in short: If I remove either one of the two physical interfaces from team1 everything is working without any errors. As soon as I enable both physical interfaces the error counters start to raise. After these tests I rebooted the slave node (media2) and added both ports to team1 again (Have you tried turning it off and on again...). After doing this, I now see TX dropped packets on the not yet rebooted media1 team1 interface. Why do I only see these errors on the team1 interface and not on em3 and em4? Currently the copy process of 20TB is still running. I think that if I reboot media1 everything will work as expected again for some time because it worked during my initial tests. But I do think that I hit a bug in the teaming driver and the raising error counters will come back. Could anybody help? Kind regards Ingo This is the used network config of team1: media1: cat /etc/sysconfig/network-scripts/ifcfg-team1_slave_0 # Generated by parse-kickstart NAME=team1 slave 0 TEAM_MASTER=team1 DEVICETYPE=TeamPort DEVICE=em3 ONBOOT=yes UUID=b7026c5b-e9cd-457c-93d2-a2799361ed90 cat /etc/sysconfig/network-scripts/ifcfg-team1_slave_1 # Generated by parse-kickstart NAME=team1 slave 1 TEAM_MASTER=team1 DEVICETYPE=TeamPort DEVICE=em4 ONBOOT=yes UUID=fbe5bc56-95f5-4f9e-a5ea-ab6b6f5e5b50 cat /etc/sysconfig/network-scripts/ifcfg-team1 # Generated by parse-kickstart UUID=4e0090cd-32d3-4c5b-be23-9f53083da4dd NAME="Team connection team1" TEAM_CONFIG="{\"runner\": {\"name\": \"roundrobin\"}}" GATEWAY= IPV6_AUTOCONF=yes BOOTPROTO=none DEVICE=team1 MTU=9000 TYPE=Team ONBOOT=yes IPV6INIT=yes DEVICETYPE=Team IPADDR0=192.168.101.31 PREFIX0=24 DEFROUTE=yes IPV4_FAILURE_FATAL=no IPV6_DEFROUTE=yes IPV6_PEERDNS=yes IPV6_PEERROUTES=yes IPV6_FAILURE_FATAL=no media2: cat /etc/sysconfig/network-scripts/ifcfg-team1_slave_0 # Generated by parse-kickstart NAME=team1 slave 0 TEAM_MASTER=team1 DEVICETYPE=TeamPort DEVICE=em3 ONBOOT=yes UUID=bfd8e77e-7eb8-47ea-ab7e-95286e073202 cat /etc/sysconfig/network-scripts/ifcfg-team1_slave_1 # Generated by parse-kickstart NAME=team1 slave 1 TEAM_MASTER=team1 DEVICETYPE=TeamPort DEVICE=em4 ONBOOT=yes UUID=93c5dfd8-3b81-4d1e-8ba9-c46f8daceb1a cat /etc/sysconfig/network-scripts/ifcfg-team1 # Generated by parse-kickstart UUID=79c843db-996c-41e4-9ee5-2a8f3da244ed NAME="Team connection team1" TEAM_CONFIG="{\"runner\": {\"name\": \"roundrobin\"}}" GATEWAY= IPV6_AUTOCONF=yes BOOTPROTO=none DEVICE=team1 MTU=9000 TYPE=Team ONBOOT=yes IPV6INIT=yes DEVICETYPE=Team IPADDR0=192.168.101.32 PREFIX0=24 DEFROUTE=yes IPV4_FAILURE_FATAL=no IPV6_DEFROUTE=yes IPV6_PEERDNS=yes IPV6_PEERROUTES=yes IPV6_FAILURE_FATAL=no Here are some system logs from both machines: ============================================================ media1: ============================================================ Nov 6 02:31:27 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412041 iface 192.168.100.31 to [1 of 10] Nov 6 02:31:29 media1 corosync[3657]: [TOTEM ] ring 0 active with no faults Nov 6 02:31:29 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412047 iface 192.168.100.31 to [1 of 10] Nov 6 02:31:31 media1 corosync[3657]: [TOTEM ] ring 0 active with no faults Nov 6 02:32:51 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412315 iface 192.168.101.31 to [1 of 10] Nov 6 02:32:53 media1 corosync[3657]: [TOTEM ] ring 1 active with no faults Nov 6 02:32:53 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412319 iface 192.168.101.31 to [1 of 10] Nov 6 02:32:54 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412321 iface 192.168.101.31 to [2 of 10] Nov 6 02:32:55 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [1 of 10] Nov 6 02:32:56 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412325 iface 192.168.101.31 to [2 of 10] Nov 6 02:32:57 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [1 of 10] Nov 6 02:32:58 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412327 iface 192.168.101.31 to [2 of 10] Nov 6 02:32:59 media1 kernel: drbd r0: PingAck did not arrive in time. Nov 6 02:32:59 media1 kernel: drbd r0: peer( Secondary -> Unknown ) conn( Connected -> NetworkFailure ) pdsk( UpToDate -> DUnknown ) Nov 6 02:32:59 media1 kernel: block drbd0: new current UUID 0C0308FA4F94F811:59E43E5FD7B26A4F:1963884285B385E6:1962884285B385E6 Nov 6 02:32:59 media1 kernel: drbd r0: asender terminated Nov 6 02:32:59 media1 kernel: drbd r0: Terminating drbd_a_r0 Nov 6 02:32:59 media1 kernel: drbd r0: Connection closed Nov 6 02:32:59 media1 kernel: drbd r0: conn( NetworkFailure -> Unconnected ) Nov 6 02:32:59 media1 kernel: drbd r0: receiver terminated Nov 6 02:32:59 media1 kernel: drbd r0: Restarting receiver thread Nov 6 02:32:59 media1 kernel: drbd r0: receiver (re)started Nov 6 02:32:59 media1 kernel: drbd r0: conn( Unconnected -> WFConnection ) Nov 6 02:32:59 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [1 of 10] Nov 6 02:32:59 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412329 iface 192.168.101.31 to [2 of 10] Nov 6 02:33:01 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412333 iface 192.168.101.31 to [3 of 10] Nov 6 02:33:01 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [2 of 10] Nov 6 02:33:01 media1 crmd[4960]: notice: do_state_transition: State transition S_IDLE -> S_POLICY_ENGINE [ input=I_PE_CALC cause=C_FSA_INTERNAL origin=abort_transition_graph ] Nov 6 02:33:01 media1 pengine[4959]: notice: unpack_config: On loss of CCM Quorum: Ignore Nov 6 02:33:01 media1 pengine[4959]: warning: unpack_rsc_op: Processing failed op monitor for res_nfsserver_mediafiles on media1: unknown error (1) Nov 6 02:33:01 media1 pengine[4959]: warning: unpack_rsc_op: Processing failed op monitor for res_nfsserver_mediafiles on media2: unknown error (1) Nov 6 02:33:01 media1 pengine[4959]: notice: process_pe_message: Calculated Transition 144: /var/lib/pacemaker/pengine/pe-input-227.bz2 Nov 6 02:33:01 media1 crmd[4960]: notice: run_graph: Transition 144 (Complete=0, Pending=0, Fired=0, Skipped=0, Incomplete=0, Source=/var/lib/pacemaker/pengine/pe-input-227.bz2): Complete Nov 6 02:33:01 media1 crmd[4960]: notice: do_state_transition: State transition S_TRANSITION_ENGINE -> S_IDLE [ input=I_TE_SUCCESS cause=C_FSA_INTERNAL origin=notify_crmd ] Nov 6 02:33:01 media1 kernel: drbd r0: Handshake successful: Agreed network protocol version 101 Nov 6 02:33:01 media1 kernel: drbd r0: Agreed to support TRIM on protocol level Nov 6 02:33:01 media1 kernel: drbd r0: Peer authenticated using 20 bytes HMAC Nov 6 02:33:01 media1 kernel: drbd r0: conn( WFConnection -> WFReportParams ) Nov 6 02:33:01 media1 kernel: drbd r0: Starting asender thread (from drbd_r_r0 [5999]) Nov 6 02:33:02 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412337 iface 192.168.101.31 to [3 of 10] Nov 6 02:33:02 media1 kernel: block drbd0: drbd_sync_handshake: Nov 6 02:33:02 media1 kernel: block drbd0: self 0C0308FA4F94F811:59E43E5FD7B26A4F:1963884285B385E6:1962884285B385E6 bits:192101 flags:0 Nov 6 02:33:02 media1 kernel: block drbd0: peer 59E43E5FD7B26A4E:0000000000000000:1963884285B385E6:1962884285B385E6 bits:0 flags:0 Nov 6 02:33:02 media1 kernel: block drbd0: uuid_compare()=1 by rule 70 Nov 6 02:33:02 media1 kernel: block drbd0: peer( Unknown -> Secondary ) conn( WFReportParams -> WFBitMapS ) pdsk( DUnknown -> Consistent ) Nov 6 02:33:02 media1 kernel: block drbd0: send bitmap stats [Bytes(packets)]: plain 0(0), RLE 185(1), total 185; compression: 100.0% Nov 6 02:33:02 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412339 iface 192.168.101.31 to [4 of 10] Nov 6 02:33:03 media1 kernel: block drbd0: receive bitmap stats [Bytes(packets)]: plain 0(0), RLE 185(1), total 185; compression: 100.0% Nov 6 02:33:03 media1 kernel: block drbd0: helper command: /sbin/drbdadm before-resync-source minor-0 Nov 6 02:33:03 media1 kernel: block drbd0: helper command: /sbin/drbdadm before-resync-source minor-0 exit code 0 (0x0) Nov 6 02:33:03 media1 kernel: block drbd0: conn( WFBitMapS -> SyncSource ) pdsk( Consistent -> Inconsistent ) Nov 6 02:33:03 media1 kernel: block drbd0: Began resync as SyncSource (will sync 919244 KB [229811 bits set]). Nov 6 02:33:03 media1 kernel: block drbd0: updated sync UUID 0C0308FA4F94F811:59E53E5FD7B26A4F:59E43E5FD7B26A4F:1963884285B385E6 Nov 6 02:33:03 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [3 of 10] Nov 6 02:33:03 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412343 iface 192.168.101.31 to [4 of 10] Nov 6 02:33:04 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412345 iface 192.168.101.31 to [5 of 10] Nov 6 02:33:05 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412347 iface 192.168.101.31 to [6 of 10] Nov 6 02:33:05 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [5 of 10] Nov 6 02:33:05 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412349 iface 192.168.101.31 to [6 of 10] Nov 6 02:33:06 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412351 iface 192.168.101.31 to [7 of 10] Nov 6 02:33:07 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412355 iface 192.168.101.31 to [8 of 10] Nov 6 02:33:07 media1 corosync[3657]: [TOTEM ] Decrementing problem counter for iface 192.168.101.31 to [7 of 10] Nov 6 02:33:07 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412357 iface 192.168.101.31 to [8 of 10] Nov 6 02:33:08 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412361 iface 192.168.101.31 to [9 of 10] Nov 6 02:33:09 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412363 iface 192.168.101.31 to [10 of 10] Nov 6 02:33:09 media1 corosync[3657]: [TOTEM ] Marking seqid 412363 ringid 1 interface 192.168.101.31 FAULTY Nov 6 02:33:11 media1 crmd[4960]: notice: do_state_transition: State transition S_IDLE -> S_POLICY_ENGINE [ input=I_PE_CALC cause=C_FSA_INTERNAL origin=abort_transition_graph ] Nov 6 02:33:11 media1 pengine[4959]: notice: unpack_config: On loss of CCM Quorum: Ignore Nov 6 02:33:11 media1 pengine[4959]: warning: unpack_rsc_op: Processing failed op monitor for res_nfsserver_mediafiles on media1: unknown error (1) Nov 6 02:33:11 media1 pengine[4959]: warning: unpack_rsc_op: Processing failed op monitor for res_nfsserver_mediafiles on media2: unknown error (1) Nov 6 02:33:11 media1 pengine[4959]: notice: process_pe_message: Calculated Transition 145: /var/lib/pacemaker/pengine/pe-input-228.bz2 Nov 6 02:33:11 media1 crmd[4960]: notice: run_graph: Transition 145 (Complete=0, Pending=0, Fired=0, Skipped=0, Incomplete=0, Source=/var/lib/pacemaker/pengine/pe-input-228.bz2): Complete Nov 6 02:33:11 media1 crmd[4960]: notice: do_state_transition: State transition S_TRANSITION_ENGINE -> S_IDLE [ input=I_TE_SUCCESS cause=C_FSA_INTERNAL origin=notify_crmd ] Nov 6 02:33:17 media1 corosync[3657]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:18 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412387 iface 192.168.101.31 to [1 of 10] Nov 6 02:33:20 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412389 iface 192.168.101.31 to [2 of 10] Nov 6 02:33:20 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412391 iface 192.168.101.31 to [3 of 10] Nov 6 02:33:21 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412393 iface 192.168.101.31 to [4 of 10] Nov 6 02:33:22 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412397 iface 192.168.101.31 to [5 of 10] Nov 6 02:33:22 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412399 iface 192.168.101.31 to [6 of 10] Nov 6 02:33:24 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412403 iface 192.168.101.31 to [7 of 10] Nov 6 02:33:31 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412421 iface 192.168.101.31 to [8 of 10] Nov 6 02:33:32 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412423 iface 192.168.101.31 to [9 of 10] Nov 6 02:33:34 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412429 iface 192.168.101.31 to [10 of 10] Nov 6 02:33:34 media1 corosync[3657]: [TOTEM ] Marking seqid 412429 ringid 1 interface 192.168.101.31 FAULTY Nov 6 02:33:36 media1 corosync[3657]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:39 media1 corosync[3657]: [TOTEM ] Incrementing problem counter for seqid 412437 iface 192.168.101.31 to [1 of 10] ============================================================ media2: ============================================================ Nov 6 02:32:59 media2 kernel: drbd r0: sock was shut down by peer Nov 6 02:32:59 media2 kernel: drbd r0: peer( Primary -> Unknown ) conn( Connected -> BrokenPipe ) pdsk( UpToDate -> DUnknown ) Nov 6 02:32:59 media2 kernel: drbd r0: short read (expected size 16) Nov 6 02:32:59 media2 kernel: drbd r0: asender terminated Nov 6 02:32:59 media2 kernel: drbd r0: Terminating drbd_a_r0 Nov 6 02:32:59 media2 kernel: drbd r0: Connection closed Nov 6 02:32:59 media2 kernel: drbd r0: conn( BrokenPipe -> Unconnected ) Nov 6 02:32:59 media2 kernel: drbd r0: receiver terminated Nov 6 02:32:59 media2 kernel: drbd r0: Restarting receiver thread Nov 6 02:32:59 media2 kernel: drbd r0: receiver (re)started Nov 6 02:32:59 media2 kernel: drbd r0: conn( Unconnected -> WFConnection ) Nov 6 02:33:01 media2 attrd[4940]: notice: attrd_trigger_update: Sending flush op to all hosts for: master-res_drbd_mediafiles (1000) Nov 6 02:33:01 media2 attrd[4940]: notice: attrd_perform_update: Sent update 16: master-res_drbd_mediafiles=1000 Nov 6 02:33:01 media2 kernel: drbd r0: Handshake successful: Agreed network protocol version 101 Nov 6 02:33:01 media2 kernel: drbd r0: Agreed to support TRIM on protocol level Nov 6 02:33:01 media2 kernel: drbd r0: Peer authenticated using 20 bytes HMAC Nov 6 02:33:01 media2 kernel: drbd r0: conn( WFConnection -> WFReportParams ) Nov 6 02:33:01 media2 kernel: drbd r0: Starting asender thread (from drbd_r_r0 [6367]) Nov 6 02:33:01 media2 kernel: block drbd0: drbd_sync_handshake: Nov 6 02:33:01 media2 kernel: block drbd0: self 59E43E5FD7B26A4E:0000000000000000:1963884285B385E6:1962884285B385E6 bits:0 flags:0 Nov 6 02:33:01 media2 kernel: block drbd0: peer 0C0308FA4F94F811:59E43E5FD7B26A4F:1963884285B385E6:1962884285B385E6 bits:192101 flags:0 Nov 6 02:33:01 media2 kernel: block drbd0: uuid_compare()=-1 by rule 50 Nov 6 02:33:01 media2 kernel: block drbd0: peer( Unknown -> Primary ) conn( WFReportParams -> WFBitMapT ) disk( UpToDate -> Outdated ) pdsk( DUnknown -> UpToDate ) Nov 6 02:33:02 media2 kernel: block drbd0: receive bitmap stats [Bytes(packets)]: plain 0(0), RLE 185(1), total 185; compression: 100.0% Nov 6 02:33:03 media2 kernel: block drbd0: send bitmap stats [Bytes(packets)]: plain 0(0), RLE 185(1), total 185; compression: 100.0% Nov 6 02:33:03 media2 kernel: block drbd0: conn( WFBitMapT -> WFSyncUUID ) Nov 6 02:33:03 media2 kernel: block drbd0: updated sync uuid 59E53E5FD7B26A4E:0000000000000000:1963884285B385E6:1962884285B385E6 Nov 6 02:33:03 media2 kernel: block drbd0: helper command: /sbin/drbdadm before-resync-target minor-0 Nov 6 02:33:03 media2 kernel: block drbd0: helper command: /sbin/drbdadm before-resync-target minor-0 exit code 0 (0x0) Nov 6 02:33:03 media2 kernel: block drbd0: conn( WFSyncUUID -> SyncTarget ) disk( Outdated -> Inconsistent ) Nov 6 02:33:03 media2 kernel: block drbd0: Began resync as SyncTarget (will sync 919244 KB [229811 bits set]). Nov 6 02:33:10 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412364 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:10 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:10 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412366 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:11 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:11 media2 attrd[4940]: notice: attrd_trigger_update: Sending flush op to all hosts for: master-res_drbd_mediafiles (10) Nov 6 02:33:11 media2 attrd[4940]: notice: attrd_perform_update: Sent update 18: master-res_drbd_mediafiles=10 Nov 6 02:33:11 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412368 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:12 media2 corosync[3690]: [TOTEM ] ring 1 active with no faults Nov 6 02:33:12 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412370 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:12 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:12 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412372 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:13 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412374 iface 192.168.101.32 to [2 of 10] Nov 6 02:33:14 media2 corosync[3690]: [TOTEM ] Decrementing problem counter for iface 192.168.101.32 to [1 of 10] Nov 6 02:33:14 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412376 iface 192.168.101.32 to [2 of 10] Nov 6 02:33:15 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412378 iface 192.168.101.32 to [3 of 10] Nov 6 02:33:15 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:15 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412380 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:16 media2 corosync[3690]: [TOTEM ] ring 1 active with no faults Nov 6 02:33:16 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412382 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:16 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:17 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412384 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:17 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:17 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412386 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:18 media2 corosync[3690]: [TOTEM ] ring 1 active with no faults Nov 6 02:33:19 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412388 iface 192.168.100.32 to [1 of 10] Nov 6 02:33:20 media2 corosync[3690]: [TOTEM ] ring 0 active with no faults Nov 6 02:33:35 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:36 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412430 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:36 media2 corosync[3690]: [TOTEM ] Automatically recovered ring 1 Nov 6 02:33:37 media2 corosync[3690]: [TOTEM ] Incrementing problem counter for seqid 412432 iface 192.168.101.32 to [1 of 10] Nov 6 02:33:38 media2 corosync[3690]: [TOTEM ] ring 1 active with no faults

3 7

[PATCH] teamd: lacp: Set COLLECTING & DISTRIBUTING flags only if the port state is CURRENT.
by Samudrala, Sridhar 18 Sep '15

18 Sep '15

Signed-off-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com> --- teamd/teamd_runner_lacp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 09899ce..f663016 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -900,7 +900,8 @@ static int lacp_port_actor_update(struct lacp_port *lacp_port) state |= INFO_STATE_LACP_TIMEOUT; if (lacp_port_selected(lacp_port)) state |= INFO_STATE_SYNCHRONIZATION; - state |= INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING; + if (lacp_port->state == PORT_STATE_CURRENT) + state |= INFO_STATE_COLLECTING | INFO_STATE_DISTRIBUTING; if (lacp_port->state == PORT_STATE_EXPIRED) state |= INFO_STATE_EXPIRED; if (lacp_port->state == PORT_STATE_DEFAULTED) -- 2.1.0

3 10

[jpirko/libteam] 05fbaf: teamd: lacp: update actor state before sending LAC...
by GitHub 18 Sep '15

18 Sep '15

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: 05fbaf2df129170b2003f3c0e06bea6d036fdf8a https://github.com/jpirko/libteam/commit/05fbaf2df129170b2003f3c0e06bea6d03… Author: Jiri Pirko <jiri(a)resnulli.us> Date: 2015-09-18 (Fri, 18 Sep 2015) Changed paths: M teamd/teamd_runner_lacp.c Log Message: ----------- teamd: lacp: update actor state before sending LACP frames We need to update actor state on lacp_callback_periodic->lacpdu_send codepath as well, preventing from sending stale info in LACPDUs. Reported-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Acked-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com> Acked-by: Flavio Leitner <fbl(a)sysclose.org>

1 0

[patch libteam] teamd: lacp: update actor state before sending LACP frames
by Jiri Pirko 17 Sep '15

17 Sep '15

We need to update actor state on lacp_callback_periodic->lacpdu_send codepath as well, preventing from sending stale info in LACPDUs. Reported-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> --- teamd/teamd_runner_lacp.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 09899ce..1cfef36 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -888,9 +888,7 @@ static void lacp_port_actor_init(struct lacp_port *lacp_port) lacp_port_actor_system_update(lacp_port); } -static int lacpdu_send(struct lacp_port *lacp_port); - -static int lacp_port_actor_update(struct lacp_port *lacp_port) +static void lacp_port_actor_update(struct lacp_port *lacp_port) { uint8_t state = 0; @@ -910,13 +908,10 @@ static int lacp_port_actor_update(struct lacp_port *lacp_port) teamd_log_dbg("%s: lacp info state: 0x%02X.", lacp_port->tdport->ifname, state); lacp_port->actor.state = state; - - if (lacp_port->periodic_on) - return 0; - - return lacpdu_send(lacp_port); } +static int lacpdu_send(struct lacp_port *lacp_port); + static int lacp_port_set_state(struct lacp_port *lacp_port, enum lacp_port_state new_state) { @@ -971,7 +966,10 @@ static int lacp_port_set_state(struct lacp_port *lacp_port, if (err) return err; - return lacp_port_actor_update(lacp_port); + lacp_port_actor_update(lacp_port); + if (lacp_port->periodic_on) + return 0; + return lacpdu_send(lacp_port); } static enum lacp_port_state lacp_port_get_state(struct lacp_port *lacp_port) @@ -1114,6 +1112,7 @@ static int lacp_callback_periodic(struct teamd_context *ctx, int events, { struct lacp_port *lacp_port = priv; + lacp_port_actor_update(lacp_port); return lacpdu_send(lacp_port); } -- 2.4.3

3 2

[jpirko/libteam] ebb94f: create run directory at teamd program start
by GitHub 16 Sep '15

16 Sep '15

Branch: refs/heads/master Home: https://github.com/jpirko/libteam Commit: ebb94f17b05fca96d4ca19d5df2501bcbeea2ea9 https://github.com/jpirko/libteam/commit/ebb94f17b05fca96d4ca19d5df2501bcbe… Author: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Date: 2015-09-16 (Wed, 16 Sep 2015) Changed paths: M teamd/teamd.c M teamd/teamd_usock.c Log Message: ----------- create run directory at teamd program start Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 0b770e3bf238f507f4c29eab0e352bb4c8a8ef01 https://github.com/jpirko/libteam/commit/0b770e3bf238f507f4c29eab0e352bb4c8… Author: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Date: 2015-09-16 (Wed, 16 Sep 2015) Changed paths: M configure.ac M teamd/teamd.h Log Message: ----------- make teamd's run directory configurable Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: a6e7faccf949c1650c4f3da765459a113c454b19 https://github.com/jpirko/libteam/commit/a6e7faccf949c1650c4f3da765459a113c… Author: Sebastian Krahmer <krahmer(a)suse.com> Date: 2015-09-16 (Wed, 16 Sep 2015) Changed paths: M configure.ac M teamd/teamd.c Log Message: ----------- drop privileges to usr/grp specified at build time Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Commit: 2797fa419702fe3f0d82988a71e95c15d080c36d https://github.com/jpirko/libteam/commit/2797fa419702fe3f0d82988a71e95c15d0… Author: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Date: 2015-09-16 (Wed, 16 Sep 2015) Changed paths: M configure.ac A teamd/teamd.conf.in Log Message: ----------- regenerate dbus policy file from template when user changed Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> Compare: https://github.com/jpirko/libteam/compare/fc7cb7cd00d7...2797fa419702

1 0

[PATCH 1/4] create run directory at teamd program start
by Pawel Wieczorkiewicz 16 Sep '15

16 Sep '15

Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> --- teamd/teamd.c | 8 ++++---- teamd/teamd_usock.c | 4 ---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/teamd/teamd.c b/teamd/teamd.c index 764e4f6..cdf1fc3 100644 --- a/teamd/teamd.c +++ b/teamd/teamd.c @@ -1621,10 +1621,6 @@ static int teamd_set_default_pid_file(struct teamd_context *ctx) if (ctx->pid_file) return 0; - err = teamd_make_rundir(); - if (err) - return err; - err = asprintf(&ctx->pid_file, TEAMD_RUN_DIR"%s.pid", ctx->team_devname); if (err == -1) { teamd_log_err("Failed allocate memory for PID file string."); @@ -1676,6 +1672,10 @@ int main(int argc, char **argv) int err; struct teamd_context *ctx; + err = teamd_make_rundir(); + if (err) + return ret; + err = teamd_context_init(&ctx); if (err) { fprintf(stderr, "Failed to init daemon context\n"); diff --git a/teamd/teamd_usock.c b/teamd/teamd_usock.c index 967f68c..c421c7a 100644 --- a/teamd/teamd_usock.c +++ b/teamd/teamd_usock.c @@ -298,10 +298,6 @@ static int teamd_usock_sock_open(struct teamd_context *ctx) int sock; int err; - err = teamd_make_rundir(); - if (err) - return err; - sock = socket(AF_UNIX, SOCK_SEQPACKET, 0); if (sock == -1) { teamd_log_err("usock: Failed to create socket."); -- 2.1.4

1 3

[PATCH 1/4] create run directory at teamd program start
by Pawel Wieczorkiewicz 16 Sep '15

16 Sep '15

2 4

[PATCH 1/4] create run directory at teamd program start
by Pawel Wieczorkiewicz 15 Sep '15

15 Sep '15

2 4

[PATCH 1/3] make teamd's run directory configurable
by Pawel Wieczorkiewicz 14 Sep '15

14 Sep '15

Signed-off-by: Pawel Wieczorkiewicz <pwieczorkiewicz(a)suse.de> Signed-off-by: Sebastian Krahmer <krahmer(a)suse.com> --- configure.ac | 8 ++++++++ teamd/teamd.c | 8 ++++---- teamd/teamd.h | 2 ++ teamd/teamd_usock.c | 4 ---- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 1115e95..302a11a 100644 --- a/configure.ac +++ b/configure.ac @@ -101,6 +101,14 @@ AC_ARG_ENABLE([zmq], fi fi +AC_ARG_WITH([run-dir], + [AS_HELP_STRING([--with-run-dir@<:@=DIR@:>@], [Teamd run time directory @<:@default=${localstatedir}@:>@])], + [case "$withval" in + yes|no|"") ;; + *) AC_DEFINE_UNQUOTED(TEAMD_RUN_DIR, "${withval}/", [TEAMD RUN DIR.]) ;; + esac] +) + AC_CHECK_PROGS([DOXYGEN], [doxygen]) if test -z "$DOXYGEN"; then AC_MSG_WARN([Doxygen not found - continuing without Doxygen support]) diff --git a/teamd/teamd.c b/teamd/teamd.c index 764e4f6..cdf1fc3 100644 --- a/teamd/teamd.c +++ b/teamd/teamd.c @@ -1621,10 +1621,6 @@ static int teamd_set_default_pid_file(struct teamd_context *ctx) if (ctx->pid_file) return 0; - err = teamd_make_rundir(); - if (err) - return err; - err = asprintf(&ctx->pid_file, TEAMD_RUN_DIR"%s.pid", ctx->team_devname); if (err == -1) { teamd_log_err("Failed allocate memory for PID file string."); @@ -1676,6 +1672,10 @@ int main(int argc, char **argv) int err; struct teamd_context *ctx; + err = teamd_make_rundir(); + if (err) + return ret; + err = teamd_context_init(&ctx); if (err) { fprintf(stderr, "Failed to init daemon context\n"); diff --git a/teamd/teamd.h b/teamd/teamd.h index 845ca18..d8ab6c8 100644 --- a/teamd/teamd.h +++ b/teamd/teamd.h @@ -67,7 +67,9 @@ static inline void TEAMD_BUG_ON(bool condition) TEAMD_BUG(); } +#ifndef TEAMD_RUN_DIR #define TEAMD_RUN_DIR "/var/run/teamd/" +#endif static inline int teamd_make_rundir(void) { diff --git a/teamd/teamd_usock.c b/teamd/teamd_usock.c index 967f68c..c421c7a 100644 --- a/teamd/teamd_usock.c +++ b/teamd/teamd_usock.c @@ -298,10 +298,6 @@ static int teamd_usock_sock_open(struct teamd_context *ctx) int sock; int err; - err = teamd_make_rundir(); - if (err) - return err; - sock = socket(AF_UNIX, SOCK_SEQPACKET, 0); if (sock == -1) { teamd_log_err("usock: Failed to create socket."); -- 2.1.4

2 7

[PATCH] update AGGREGATION flag in actor state before sending LACP frames.
by Samudrala, Sridhar 11 Sep '15

11 Sep '15

Currently AGGREGATION flag is only set when there is a change in port state. Adding a 2nd port should cause the AGGREGATION flag of the first port to be changed to 'Yes' and removing the last but one port should cause the AGGREGATION flag of the remaining port to be changed to 'No'. A simple fix is set AGGREGATION flag before sending LACP frames based on the number of ports in the team. Signed-off-by: Sridhar Samudrala <sridhar.samudrala(a)intel.com> --- teamd/teamd_runner_lacp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index 09899ce..4f46ebf 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -1034,6 +1034,11 @@ static int lacpdu_send(struct lacp_port *lacp_port) lacpdu.actor = lacp_port->actor; lacpdu.partner = lacp_port->partner; + if (teamd_port_count(lacp_port->ctx) > 1) + lacp_port->actor.state |= INFO_STATE_AGGREGATION; + else + lacp_port->actor.state &= ~INFO_STATE_AGGREGATION; + err = teamd_sendto(lacp_port->sock, &lacpdu, sizeof(lacpdu), 0, (struct sockaddr *) &ll_slow, sizeof(ll_slow)); return err; -- 2.1.0

3 5

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam September 2015