libteam May 2022

libteam@lists.fedorahosted.org

1 participants
3 discussions

[PATCH] libteamdctl: validate the bus name before using it
by Xin Long 04 Jul '22

04 Jul '22

Using bus name without validating it will cause core dump generated, and it can be reproduced by: # ip link add dummy0.1 type dummy # teamdctl dummy0.1 state dump This is normally a bug in some application using the D-Bus library. D-Bus not built with -rdynamic so unable to print a backtrace Aborted (core dumped) Doing this many times can even create too many core files, customers may complain about it. This is triggered when calling cli_method_call("ConfigDump") in cli_init(), so fix it by returning err in cli->init/cli_dbus_init() if the bus name fails to validate. Note this is safe, as with dbus, we can't use invalid dbus name to create the team dev either. Fixes: d8163e34c25c ("libteamdctl: do test method call instead or Introspect call") Reported-by: Uday Patel <upatel(a)redhat.com> Signed-off-by: Xin Long <lucien.xin(a)gmail.com> --- libteamdctl/cli_dbus.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libteamdctl/cli_dbus.c b/libteamdctl/cli_dbus.c index dfef5c4..242ef86 100644 --- a/libteamdctl/cli_dbus.c +++ b/libteamdctl/cli_dbus.c @@ -183,12 +183,17 @@ static int cli_dbus_init(struct teamdctl *tdc, const char *team_name, void *priv if (ret == -1) return -errno; + err = -EINVAL; dbus_error_init(&error); + if (!dbus_validate_bus_name(cli_dbus->service_name, &error)) { + err(tdc, "dbus: Could not validate bus name: %s - %s", + error.name, error.message); + goto free_service_name; + } cli_dbus->conn = dbus_bus_get(DBUS_BUS_SYSTEM, &error); if (!cli_dbus->conn) { err(tdc, "dbus: Could not acquire the system bus: %s - %s", error.name, error.message); - err = -EINVAL; goto free_service_name; } err = 0; -- 2.31.1

2 3

[PATCH] options: move option temporary check after the err check
by Xin Long 27 Jun '22

27 Jun '22

option is set only if err returned from update_option() is 0, so check err first before checking option->temporary. Otherwise, it may results in a dereference of an undefined pointer value. Fixes: 8180763d6f82 ("libteam: always add newly created option to option list") Signed-off-by: Xin Long <lucien.xin(a)gmail.com> --- libteam/options.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libteam/options.c b/libteam/options.c index 71cc99e..51e233e 100644 --- a/libteam/options.c +++ b/libteam/options.c @@ -688,10 +688,10 @@ static int local_set_option_value(struct team_handle *th, err = update_option(th, &option, opt_id, opt_type, data, data_len, true, true); - if (option->temporary) - destroy_option(option); if (err) return err; + if (option->temporary) + destroy_option(option); return 0; } -- 2.27.0

2 1

Release anytime soon?
by J Farkas 27 Jun '22

27 Jun '22

Hi! I'm using the latest code from github, and I would also like to have it packaged for a distribution which does not have libteam yet - https://github.com/void-linux/void-packages/pull/33028 They are making a point that it's preferable using a proper upstream release. As far as I can see, the commits since 1.31 appear somewhat important. On the other hand, even the latest github changes are somewhat old, so I can't see anything unstable about it. For the benefit of a cleaner packaging, are there any plans to make a numbered release anytime soon? Janos

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

libteam May 2022