Hi.
Now I am trying to review gnome-menu-extended.
https://bugzilla.redhat.com/show_bug.cgi?id=426026
The main purpose of this package is to add KDE related submenus to GNOME panel menu.
What I cannot judge for now is about the %postun scriptlet of the spec file:
------------------------------------------------------------- %postun rm -f /home/*/.local/share/applications/%{name}.desktop rm -f /root/.local/share/applications/%{name}.desktop --------------------------------------------------------------
Well, at least - if [ $1 = 0 ] ; then ..... ; fi is needed - This scriptlet cannot handle the case in which $HOME is not /home
However the point is that this scriptlet is trying to handle (in this case delete) files under $HOME directory at %postun. Is this allowed?
Regards, Mamoru
On Wed, Feb 27, 2008 at 10:24:04PM +0900, Mamoru Tasaka wrote:
Hi.
However the point is that this scriptlet is trying to handle (in this case delete) files under $HOME directory at %postun. Is this allowed?
In any case it shouldn't be allowed. A script can be done that makes the same and a documentation file could be done too.
-- Pat
"MT" == Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp writes:
MT> rm -f /home/*/.local/share/applications/%{name}.desktop
Absolutely, positively broken. Aside for all of the obvious stuff, consider that it doesn't even do what you expect on a bunch of systems:
ls /home
tibbs/
df ~dave
Filesystem 1K-blocks Used Available Use% Mounted on nas07:/export/h-dave/dave 41284928 27274880 13970048 67% /home/dave
ls /home
dave/ tibbs/
df /home
Filesystem 1K-blocks Used Available Use% Mounted on - 0 0 0 - /home
Hooray for autofs. (Yeah, I could make the mountpoint browseable, but there's really no need to do so and I don't really like mount storms.) /home is mine; packages cannot ever safely touch anything there.
- J<
Tom "spot" Callaway wrote:
On Wed, 2008-02-27 at 11:17 -0600, Jason L Tibbitts III wrote:
/home is mine; packages cannot ever safely touch anything there.
This seems like a succinct point to add to the Guidelines.
+1
Regards,
Hans
packaging@lists.fedoraproject.org
-
Hans de Goede -
Jason L Tibbitts III -
Mamoru Tasaka -
Patrice Dumas -
Rex Dieter -
Tom Callaway