Hi everybody,
As I promised, I drafted update to Ruby guidelines. You can see the changes here [1]. This is the summary:
* Drop reference to EPEL5 * Use %setup macro to expand .gems since RPM 4.14 * Use %setup macro to expand the external test suite. * Drop the note, which recommends not shipping test suite, since we typically keep them despite this note * Updated test framework section to meet the current state. * Bundler and coverage frameworks usage discouraged. * Reference %gemspec_{add,remove}_dep macros.
And although I promised, that this wont be breaking changes, there is one exception :/
The issue is with %gemspec_{add,remove}_dep macros, which currently expect the .gemspec file in the directory with the sources. However, the %setup macro generates the .gemspec file directly in %{_builddir} (i.e. one level above). I should probably update the macros to find the .gemspec there by default. This might break some packages (who is actually using the macros except me?), but it won't be worse then RubyGems freezing the strings in patch release, right? In other case, you would need always specify the path to the .gemspec ...
So what do you think? Anything I missed or something I got wrong? Please let me know.
Vít
[1] https://fedoraproject.org/w/index.php?title=User%3AVondruch%2FDraft_RubyGuid...
Actually, I forgot two things:
1) I already updated gem2rpm, so if you are by a chance using Rawhide or you explicitly specify the rawhide template, you'll get the .gemspec prepared according to the draft.
2) I dared to update two packages by this draft, so you can look at rubygem-eventmachine [1] or rubygem-fakefs [2] to see the changes in practice.
Vít
[1] https://src.fedoraproject.org/rpms/rubygem-eventmachine/c/9c7af37989c3d7f93f...
[2] https://src.fedoraproject.org/rpms/rubygem-fakefs/c/591d36d166acce49824312bd...
Dne 23.8.2017 v 15:30 Vít Ondruch napsal(a):
Hi everybody,
As I promised, I drafted update to Ruby guidelines. You can see the changes here [1]. This is the summary:
- Drop reference to EPEL5
- Use %setup macro to expand .gems since RPM 4.14
- Use %setup macro to expand the external test suite.
- Drop the note, which recommends not shipping test suite, since we
typically keep them despite this note
- Updated test framework section to meet the current state.
- Bundler and coverage frameworks usage discouraged.
- Reference %gemspec_{add,remove}_dep macros.
And although I promised, that this wont be breaking changes, there is one exception :/
The issue is with %gemspec_{add,remove}_dep macros, which currently expect the .gemspec file in the directory with the sources. However, the %setup macro generates the .gemspec file directly in %{_builddir} (i.e. one level above). I should probably update the macros to find the .gemspec there by default. This might break some packages (who is actually using the macros except me?), but it won't be worse then RubyGems freezing the strings in patch release, right? In other case, you would need always specify the path to the .gemspec ...
So what do you think? Anything I missed or something I got wrong? Please let me know.
Vít
[1] https://fedoraproject.org/w/index.php?title=User%3AVondruch%2FDraft_RubyGuid...
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
Since there was no (negative) feedback, I proposed the draft to FPC for a review:
https://pagure.io/packaging-committee/issue/710
Vít
Dne 23.8.2017 v 15:36 Vít Ondruch napsal(a):
Actually, I forgot two things:
- I already updated gem2rpm, so if you are by a chance using Rawhide or
you explicitly specify the rawhide template, you'll get the .gemspec prepared according to the draft.
- I dared to update two packages by this draft, so you can look at
rubygem-eventmachine [1] or rubygem-fakefs [2] to see the changes in practice.
Vít
[1] https://src.fedoraproject.org/rpms/rubygem-eventmachine/c/9c7af37989c3d7f93f...
[2] https://src.fedoraproject.org/rpms/rubygem-fakefs/c/591d36d166acce49824312bd...
Dne 23.8.2017 v 15:30 Vít Ondruch napsal(a):
Hi everybody,
As I promised, I drafted update to Ruby guidelines. You can see the changes here [1]. This is the summary:
- Drop reference to EPEL5
- Use %setup macro to expand .gems since RPM 4.14
- Use %setup macro to expand the external test suite.
- Drop the note, which recommends not shipping test suite, since we
typically keep them despite this note
- Updated test framework section to meet the current state.
- Bundler and coverage frameworks usage discouraged.
- Reference %gemspec_{add,remove}_dep macros.
And although I promised, that this wont be breaking changes, there is one exception :/
The issue is with %gemspec_{add,remove}_dep macros, which currently expect the .gemspec file in the directory with the sources. However, the %setup macro generates the .gemspec file directly in %{_builddir} (i.e. one level above). I should probably update the macros to find the .gemspec there by default. This might break some packages (who is actually using the macros except me?), but it won't be worse then RubyGems freezing the strings in patch release, right? In other case, you would need always specify the path to the .gemspec ...
So what do you think? Anything I missed or something I got wrong? Please let me know.
Vít
[1] https://fedoraproject.org/w/index.php?title=User%3AVondruch%2FDraft_RubyGuid...
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
Just FTR, I was asked by FPC to make the guidelines compatible with F26 and older Fedoras, so here is the change:
https://fedoraproject.org/w/index.php?title=User:Vondruch/Draft_RubyGuidelin...
Vít
Dne 30.8.2017 v 15:16 Vít Ondruch napsal(a):
Since there was no (negative) feedback, I proposed the draft to FPC for a review:
https://pagure.io/packaging-committee/issue/710
Vít
Dne 23.8.2017 v 15:36 Vít Ondruch napsal(a):
Actually, I forgot two things:
- I already updated gem2rpm, so if you are by a chance using Rawhide or
you explicitly specify the rawhide template, you'll get the .gemspec prepared according to the draft.
- I dared to update two packages by this draft, so you can look at
rubygem-eventmachine [1] or rubygem-fakefs [2] to see the changes in practice.
Vít
[1] https://src.fedoraproject.org/rpms/rubygem-eventmachine/c/9c7af37989c3d7f93f...
[2] https://src.fedoraproject.org/rpms/rubygem-fakefs/c/591d36d166acce49824312bd...
Dne 23.8.2017 v 15:30 Vít Ondruch napsal(a):
Hi everybody,
As I promised, I drafted update to Ruby guidelines. You can see the changes here [1]. This is the summary:
- Drop reference to EPEL5
- Use %setup macro to expand .gems since RPM 4.14
- Use %setup macro to expand the external test suite.
- Drop the note, which recommends not shipping test suite, since we
typically keep them despite this note
- Updated test framework section to meet the current state.
- Bundler and coverage frameworks usage discouraged.
- Reference %gemspec_{add,remove}_dep macros.
And although I promised, that this wont be breaking changes, there is one exception :/
The issue is with %gemspec_{add,remove}_dep macros, which currently expect the .gemspec file in the directory with the sources. However, the %setup macro generates the .gemspec file directly in %{_builddir} (i.e. one level above). I should probably update the macros to find the .gemspec there by default. This might break some packages (who is actually using the macros except me?), but it won't be worse then RubyGems freezing the strings in patch release, right? In other case, you would need always specify the path to the .gemspec ...
So what do you think? Anything I missed or something I got wrong? Please let me know.
Vít
[1] https://fedoraproject.org/w/index.php?title=User%3AVondruch%2FDraft_RubyGuid...
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
ruby-sig mailing list -- ruby-sig@lists.fedoraproject.org To unsubscribe send an email to ruby-sig-leave@lists.fedoraproject.org
ruby-sig@lists.fedoraproject.org