On Sex, 2015-06-26 at 17:14 -0700, Gerald B. Cox wrote:
On Fri, Jun 26, 2015 at 2:32 PM, Sérgio Basto sergio@serjux.com wrote: Instead : Source0: https://github.com/$OWNER/$PROJECT/archive/%%7Bcommit%7D/$PROJECT-%%7Bcommit...
Source0: https://github.com/$OWNER/$PROJECT/archive/%{commit}/$PROJECT-%{shortcommit}.tar.gz
Sergio,
You mean you don't like the full 40-character-hash? ;-)
Yes, we can avoid file names with 40-character-hash.
I actually thought of that since the full 40-character hash is stored in the tar file anyway; the issue however is that GitHub doesn't care if you provide the short value or not. The file you get will be named with the full 40-character hash. Since that is the case, I left it using the %{commit}. Now, if you want to rename the file being downloaded, you can do that by appending #/$newname as shown in the Bitbucket example.
The only difference is the filename length instead we have: audacity-dea351aa4820efd7ce8c2254930f942a6590472b.tar.gz we will have a filename much shorter: audacity-dea351a.tar.gz
The content of tar.gz is exactly the same and the rest of spec doesn't change. This suggestion was inspired on [1].
[1] http://pkgs.fedoraproject.org/cgit/simarrange.git/tree/simarrange.spec
Thanks,