On Sat, Sep 26, 2015 at 3:42 PM, Remi Collet Fedora@famillecollet.com wrote:
Le 26/09/2015 09:14, Ville Skyttä a écrit :
Check added in rpmlint: https://github.com/rpm-software-management/rpmlint/commit/3c42240d8e12bd9a59...
IIUC, this change will detect "/usr/bin/env" and report it as wrong whatever the language is.
The initial discussion was about python. I can understand the need in this case.
For other language, it can make sense to use /usr/bin/env.
Especially, with PHP where compatibility is usually very good, and where upstream test against various versions (travis)
And this allow to run the packaged command against SCL installed PHP runtime. A good example is "PHPUnit" which works perfectly with PHP 5.4, 5.5, 5.6 and even 7.0.
I think, following upstream is better in this case, else you loose most interest of providing such app. in our repository, and I have started to "restore" upstream shebang in some of my packages.
Yes... I know,.. SCL are RHEL only :(
So here comes the question, should fedora-review enable env checking as default?