Hi, I was going through most frequent crashers in Fedora 25 and vino is in TOP10. When I looked at it I realized it crashed on Wayland because for screen sharing you need X. [1] It's a bit unfortunate that we have vino, which by default doesn't work, in the default installation and its functionality is exposed in Control Center. I wonder if it'd make a sense to patch the sharing module in the control center to check if the session is running on Wayland and if so, to disable the dialog.
My understanding is that screen sharing is moving to the compositor or Pinos [2] and vino will be deprecated, but in the meantime we shouldn't expose its functionality on Wayland.
Jiri
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1394599 [2] https://wiki.gnome.org/Initiatives/Wayland/Remoting
On Wed, 2016-11-16 at 10:36 +0100, Jiri Eischmann wrote:
Hi, I was going through most frequent crashers in Fedora 25 and vino is in TOP10. When I looked at it I realized it crashed on Wayland because for screen sharing you need X. [1] It's a bit unfortunate that we have vino, which by default doesn't work, in the default installation and its functionality is exposed in Control Center. I wonder if it'd make a sense to patch the sharing module in the control center to check if the session is running on Wayland and if so, to disable the dialog.
My understanding is that screen sharing is moving to the compositor or Pinos [2] and vino will be deprecated, but in the meantime we shouldn't expose its functionality on Wayland.
Thanks for bringing that up.
Yes, Jonas has in the past worked on prototyping screensharing in the compositor, using pinos. We will have to complete this work and land it. In the meantime, vino should of course not crash, but exit cleanly if X is not available.
On Wed, 2016-11-16 at 05:46 -0500, Matthias Clasen wrote:
Yes, Jonas has in the past worked on prototyping screensharing in the compositor, using pinos. We will have to complete this work and land it. In the meantime, vino should of course not crash, but exit cleanly if X is not available.
I think it's also important to hide it from the control-center panel, like Jiri suggested.
Michael
On Wed, 2016-11-16 at 08:26 -0600, Michael Catanzaro wrote:
On Wed, 2016-11-16 at 05:46 -0500, Matthias Clasen wrote:
Yes, Jonas has in the past worked on prototyping screensharing in the compositor, using pinos. We will have to complete this work and land it. In the meantime, vino should of course not crash, but exit cleanly if X is not available.
I think it's also important to hide it from the control-center panel, like Jiri suggested.
Bastien, can we do that ?
Filed https://bugzilla.gnome.org/show_bug.cgi?id=774553
----- Original Message -----
On Wed, 2016-11-16 at 08:26 -0600, Michael Catanzaro wrote:
On Wed, 2016-11-16 at 05:46 -0500, Matthias Clasen wrote:
Yes, Jonas has in the past worked on prototyping screensharing in the compositor, using pinos. We will have to complete this work and land it. In the meantime, vino should of course not crash, but exit cleanly if X is not available.
I think it's also important to hide it from the control-center panel, like Jiri suggested.
Bastien, can we do that ?
On Wed, 2016-11-16 at 10:36 +0100, Jiri Eischmann wrote:
Hi, I was going through most frequent crashers in Fedora 25 and vino is in TOP10. When I looked at it I realized it crashed on Wayland because for screen sharing you need X. [1] It's a bit unfortunate that we have vino, which by default doesn't work, in the default installation and its functionality is exposed in Control Center. I wonder if it'd make a sense to patch the sharing module in the control center to check if the session is running on Wayland and if so, to disable the dialog.
My understanding is that screen sharing is moving to the compositor or Pinos [2] and vino will be deprecated, but in the meantime we shouldn't expose its functionality on Wayland.
Yes, please do something like this. If we'd found it earlier I would actually nominate it as a blocker as violation of 'All applications that can be launched using the standard graphical mechanism of a release-blocking desktop after a default installation of that desktop must start successfully and withstand a basic functionality test.', but I don't think I'm going to rock the boat and do it now. Having it as a 0-day update would be very good, though.
----- Original Message -----
On Wed, 2016-11-16 at 10:36 +0100, Jiri Eischmann wrote:
Hi, I was going through most frequent crashers in Fedora 25 and vino is in TOP10. When I looked at it I realized it crashed on Wayland because for screen sharing you need X. [1] It's a bit unfortunate that we have vino, which by default doesn't work, in the default installation and its functionality is exposed in Control Center. I wonder if it'd make a sense to patch the sharing module in the control center to check if the session is running on Wayland and if so, to disable the dialog.
My understanding is that screen sharing is moving to the compositor or Pinos [2] and vino will be deprecated, but in the meantime we shouldn't expose its functionality on Wayland.
Yes, please do something like this. If we'd found it earlier I would actually nominate it as a blocker as violation of 'All applications that can be launched using the standard graphical mechanism of a release-blocking desktop after a default installation of that desktop must start successfully and withstand a basic functionality test.', but I don't think I'm going to rock the boat and do it now. Having it as a 0-day update would be very good, though.
It doesn't match the "using the standard graphical mechanism". Vino only appears as a toggle in the Sharing Settings, not in the applications list.
desktop@lists.fedoraproject.org
-
Adam Williamson -
Bastien Nocera -
Jiri Eischmann -
Matthias Clasen -
Michael Catanzaro