--- config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true
On Thu, Aug 28, 2014 at 5:24 PM, Paul W. Frields stickster@gmail.com wrote:
config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true -- 1.9.3
-- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
The list must end with a semicolon for this to work.
On Thu, Aug 28, 2014 at 05:39:34PM +0300, Elad Alfassa wrote:
On Thu, Aug 28, 2014 at 5:24 PM, Paul W. Frields stickster@gmail.com wrote:
config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true -- 1.9.3
-- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
The list must end with a semicolon for this to work.
/me so sad. I misread the desktop file specification and though the ending semicolon was only needed if you had an empty string in a string(s) or localestring(s) value. *sigh
And it should be _Keywords, so that the keywords are translated.
You might also add a mention of what those are, with a translator comment above, for example: # Translators: those are keywords for the firewall configuration tool
Cheers
----- Original Message -----
On Thu, Aug 28, 2014 at 05:39:34PM +0300, Elad Alfassa wrote:
On Thu, Aug 28, 2014 at 5:24 PM, Paul W. Frields stickster@gmail.com wrote:
config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true -- 1.9.3
-- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
The list must end with a semicolon for this to work.
/me so sad. I misread the desktop file specification and though the ending semicolon was only needed if you had an empty string in a string(s) or localestring(s) value. *sigh
-- Paul W. Frields http://paul.frields.org/ gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233 5906 ACDB C937 BD11 3717 http://redhat.com/ - - - - http://pfrields.fedorapeople.org/ The open source story continues to grow: http://opensource.com -- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
On 08/28/2014 04:47 PM, Paul W. Frields wrote:
On Thu, Aug 28, 2014 at 05:39:34PM +0300, Elad Alfassa wrote:
On Thu, Aug 28, 2014 at 5:24 PM, Paul W. Frields stickster@gmail.com wrote:
config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true -- 1.9.3
-- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
The list must end with a semicolon for this to work.
/me so sad. I misread the desktop file specification and though the ending semicolon was only needed if you had an empty string in a string(s) or localestring(s) value. *sigh
Applied upstream with the ending semicolon: https://git.fedorahosted.org/cgit/firewalld.git/commit/?id=7a8ac65063ee777db...
Thanks !
-- Jiri
--- config/firewall-config.desktop.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 621e8ec..f8bcb81 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,7 +3,8 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; -Keywords=firewall;network;security;iptables;netfilter; +# Translators: These are searchable keywords for the firewall configuration tool +_Keywords=firewall;network;security;iptables;netfilter; Exec=/usr/bin/firewall-config Type=Application StartupNotify=true
On 08/28/2014 06:05 PM, Paul W. Frields wrote:
config/firewall-config.desktop.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 621e8ec..f8bcb81 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,7 +3,8 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; -Keywords=firewall;network;security;iptables;netfilter; +# Translators: These are searchable keywords for the firewall configuration tool +_Keywords=firewall;network;security;iptables;netfilter; Exec=/usr/bin/firewall-config Type=Application StartupNotify=true
Thanks. https://git.fedorahosted.org/cgit/firewalld.git/commit/?id=aed5233fda5d1b3e5...
And the i18n support? And the translation comment?
----- Original Message -----
On 08/28/2014 04:47 PM, Paul W. Frields wrote:
On Thu, Aug 28, 2014 at 05:39:34PM +0300, Elad Alfassa wrote:
On Thu, Aug 28, 2014 at 5:24 PM, Paul W. Frields stickster@gmail.com wrote:
config/firewall-config.desktop.in | 1 + 1 file changed, 1 insertion(+)
diff --git a/config/firewall-config.desktop.in b/config/firewall-config.desktop.in index 794d8e9..ee9108b 100644 --- a/config/firewall-config.desktop.in +++ b/config/firewall-config.desktop.in @@ -3,6 +3,7 @@ _Name=Firewall _Comment=Firewall Configuration Icon=firewall-config Categories=System;Settings;Security; +Keywords=firewall;network;security;iptables;netfilter Exec=/usr/bin/firewall-config Type=Application StartupNotify=true -- 1.9.3
-- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
The list must end with a semicolon for this to work.
/me so sad. I misread the desktop file specification and though the ending semicolon was only needed if you had an empty string in a string(s) or localestring(s) value. *sigh
Applied upstream with the ending semicolon: https://git.fedorahosted.org/cgit/firewalld.git/commit/?id=7a8ac65063ee777db...
Thanks !
-- Jiri -- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
On Thu, Aug 28, 2014 at 01:00:32PM -0400, Bastien Nocera wrote:
And the i18n support? And the translation comment?
Hopefully you saw my earlier second patch?
I sent my mail an hour earlier than your second patch showed up. Not sure why it took so long to reach the list though.
----- Original Message -----
On Thu, Aug 28, 2014 at 01:00:32PM -0400, Bastien Nocera wrote:
And the i18n support? And the translation comment?
Hopefully you saw my earlier second patch?
-- Paul W. Frields http://paul.frields.org/ gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233 5906 ACDB C937 BD11 3717 http://redhat.com/ - - - - http://pfrields.fedorapeople.org/ The open source story continues to grow: http://opensource.com -- desktop mailing list desktop@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/desktop
On Thu, Aug 28, 2014 at 02:39:01PM -0400, Bastien Nocera wrote:
I sent my mail an hour earlier than your second patch showed up. Not sure why it took so long to reach the list though.
It's OK, I sent a patch for that too. ;-D
desktop@lists.fedoraproject.org